disable Google Translate service during Lighthouse run #897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankenny
commented
Nov 2, 2016
| @@ -20,7 +20,7 @@ | |||
| const withoutJsAudit = require('../../audits/without-javascript.js'); | |||
| const assert = require('assert'); | |||
|
|
|||
| describe.only('Progressive Enhancement: without javascript audit', () => { | |||
| describe('Progressive Enhancement: without javascript audit', () => { | |||
paulirish
reviewed
Nov 2, 2016
| @@ -53,6 +53,7 @@ class ChromeLauncher { | |||
| const flags = [ | |||
| '--remote-debugging-port=9222', | |||
| '--disable-extensions', | |||
| '--disable-translate', | |||
There was a problem hiding this comment.
lets add this too:
--disable-default-apps"Disables installation of default apps on first run. This is used during automated testing"
There was a problem hiding this comment.
there's also
which apparently will flip off some authentication work
chrome_session_manager.cc - Code Search
paulirish
approved these changes
Nov 2, 2016
|
nice work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #896