Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n: placeholders #9114

Merged
merged 77 commits into from
Jul 24, 2019
Merged

i18n: placeholders #9114

merged 77 commits into from
Jul 24, 2019

Commits on Jun 3, 2019

  1. basic format

    @exterkamp
    exterkamp committed Jun 3, 2019
    Configuration menu
    Copy the full SHA
    656acce View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2019

  1. Basic placeholder syntax.

    @exterkamp
    exterkamp committed Jun 4, 2019
    Configuration menu
    Copy the full SHA
    fc762a5 View commit details
    Browse the repository at this point in the history

  2. minor corrections

    @exterkamp
    exterkamp committed Jun 4, 2019
    Configuration menu
    Copy the full SHA
    d1cdeab View commit details
    Browse the repository at this point in the history

  3. iterating

    @exterkamp
    exterkamp committed Jun 4, 2019
    Configuration menu
    Copy the full SHA
    74e11c1 View commit details
    Browse the repository at this point in the history

  4. Added ICU plural and ICU select examples.

    @exterkamp
    exterkamp committed Jun 4, 2019
    Configuration menu
    Copy the full SHA
    981e028 View commit details
    Browse the repository at this point in the history

  5. Gender example has replacement AND ICU.

    @exterkamp
    exterkamp committed Jun 4, 2019
    Configuration menu
    Copy the full SHA
    6d2dd5d View commit details
    Browse the repository at this point in the history

  6. less stutter syntax

    @exterkamp
    exterkamp committed Jun 4, 2019
    Configuration menu
    Copy the full SHA
    f22ee1b View commit details
    Browse the repository at this point in the history

  7. docs

    @exterkamp
    exterkamp committed Jun 4, 2019
    Configuration menu
    Copy the full SHA
    c66c0c6 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2019

  1. Updated README.

    @exterkamp
    exterkamp committed Jun 12, 2019
    Configuration menu
    Copy the full SHA
    70a5a07 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2019

  1. correct-strings

    @exterkamp
    exterkamp committed Jul 3, 2019
    Configuration menu
    Copy the full SHA
    a7fc83a View commit details
    Browse the repository at this point in the history

  2. updated i18n.js

    @exterkamp
    exterkamp committed Jul 3, 2019
    Configuration menu
    Copy the full SHA
    0de5485 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into placeholders

    @exterkamp
    exterkamp committed Jul 3, 2019
    Configuration menu
    Copy the full SHA
    f8650eb View commit details
    Browse the repository at this point in the history

  4. remove unused from correct-strings

    @exterkamp
    exterkamp committed Jul 3, 2019
    Configuration menu
    Copy the full SHA
    37dc2ae View commit details
    Browse the repository at this point in the history

  5. exported correct-strings to be reused to import. ts first pass on col… 

    …lect & correct.
    @exterkamp
    exterkamp committed Jul 3, 2019
    Configuration menu
    Copy the full SHA
    58c7ded View commit details
    Browse the repository at this point in the history

  6. first pass at new UIStrings format.

    @exterkamp
    exterkamp committed Jul 3, 2019
    Configuration menu
    Copy the full SHA
    ad01bdd View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2019

  1. new jsdoc format for comments + _very_ basic parsing.

    @exterkamp
    exterkamp committed Jul 4, 2019
    3 Configuration menu
    Copy the full SHA
    4182889 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2019

  1. Better parsing, filled out lh-error descriptions.

    @exterkamp
    exterkamp committed Jul 5, 2019
    Configuration menu
    Copy the full SHA
    8b0f8ea View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2019

  1. Fixed tests, made unminified-css and doc-title back to normal.

    @exterkamp
    exterkamp committed Jul 7, 2019
    Configuration menu
    Copy the full SHA
    ddf8171 View commit details
    Browse the repository at this point in the history

  2. Updating readme for i18n.

    @exterkamp
    exterkamp committed Jul 7, 2019
    Configuration menu
    Copy the full SHA
    705ffb6 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2019

  1. More readme updates.

    @exterkamp
    exterkamp committed Jul 8, 2019
    Configuration menu
    Copy the full SHA
    902c2f7 View commit details
    Browse the repository at this point in the history

  2. Move collect code into seperate util file for testing, and the tests … 

    …for it
    @exterkamp
    exterkamp committed Jul 8, 2019
    Configuration menu
    Copy the full SHA
    4507138 View commit details
    Browse the repository at this point in the history

  3. Add placeholder baking tests.

    @exterkamp
    exterkamp committed Jul 8, 2019
    Configuration menu
    Copy the full SHA
    29e29df View commit details
    Browse the repository at this point in the history

  4. readme updates

    @exterkamp
    exterkamp committed Jul 8, 2019
    Configuration menu
    Copy the full SHA
    393beb6 View commit details
    Browse the repository at this point in the history

  5. More readme details.

    @exterkamp
    exterkamp committed Jul 8, 2019
    Configuration menu
    Copy the full SHA
    799084c View commit details
    Browse the repository at this point in the history

  6. Added test for ICU with examples, fixed audits that violated this.

    @exterkamp
    exterkamp committed Jul 8, 2019
    Configuration menu
    Copy the full SHA
    86e1593 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2019

  1. Patrick foodback

    @exterkamp
    exterkamp committed Jul 9, 2019
    Configuration menu
    Copy the full SHA
    6160402 View commit details
    Browse the repository at this point in the history

  2. ICU select & ordinal readme examples. made runtime example more accur… 

    …ate.
    @exterkamp
    exterkamp committed Jul 9, 2019
    Configuration menu
    Copy the full SHA
    02e8977 View commit details
    Browse the repository at this point in the history

  3. collection-util docstrings

    @exterkamp
    exterkamp committed Jul 9, 2019
    Configuration menu
    Copy the full SHA
    f5083b8 View commit details
    Browse the repository at this point in the history

  4. remove old console log

    @exterkamp
    exterkamp committed Jul 9, 2019
    Configuration menu
    Copy the full SHA
    5aca05a View commit details
    Browse the repository at this point in the history

  5. update assert on strings to new en-US

    @exterkamp
    exterkamp committed Jul 9, 2019
    Configuration menu
    Copy the full SHA
    ee3e235 View commit details
    Browse the repository at this point in the history

  6. polish

    @exterkamp
    exterkamp committed Jul 9, 2019
    Configuration menu
    Copy the full SHA
    6b8297d View commit details
    Browse the repository at this point in the history

  7. refactoring conversion method, testing conversion to follow.

    @exterkamp
    exterkamp committed Jul 9, 2019
    Configuration menu
    Copy the full SHA
    77fcd92 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2019

  1. brendan readme foodback.

    @exterkamp
    exterkamp committed Jul 10, 2019
    Configuration menu
    Copy the full SHA
    7252f3d View commit details
    Browse the repository at this point in the history

  2. check for empty descriptions

    @exterkamp
    exterkamp committed Jul 10, 2019
    Configuration menu
    Copy the full SHA
    d4dd3ac View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2019

  1. Use UIString as primary fallback, since it is just en. Update fallbac… 

    …k msg name to be more clear.
    @exterkamp
    exterkamp committed Jul 11, 2019
    Configuration menu
    Copy the full SHA
    996ee5c View commit details
    Browse the repository at this point in the history

  2. Untrack pre-locales.

    @exterkamp
    exterkamp committed Jul 11, 2019
    Configuration menu
    Copy the full SHA
    4ff414a View commit details
    Browse the repository at this point in the history

  3. reorganized collect and correct

    @exterkamp
    exterkamp committed Jul 11, 2019
    Configuration menu
    Copy the full SHA
    588f574 View commit details
    Browse the repository at this point in the history

  4. fixup collect-string output

    @paulirish
    paulirish committed Jul 11, 2019
    Configuration menu
    Copy the full SHA
    2b17130 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2019

  1. Paul foodback. Readme updates, updated yarn cmds, updated ctc naming … 

    …part 1, updated baking script. en-XL has WP strings now.
    @exterkamp
    exterkamp committed Jul 12, 2019
    Configuration menu
    Copy the full SHA
    570a6cc View commit details
    Browse the repository at this point in the history

  2. Wording of CTC and LHL in readme and docstrings. Removed mkdirp. Adde… 

    …d .ctc.json to yarn clean.
    @exterkamp
    exterkamp committed Jul 12, 2019
    Configuration menu
    Copy the full SHA
    dcc7cc7 View commit details
    Browse the repository at this point in the history

  3. rip my hopes and dreams, thanks linter.

    @exterkamp
    exterkamp committed Jul 12, 2019
    Configuration menu
    Copy the full SHA
    7743cda View commit details
    Browse the repository at this point in the history

  4. polish to package and to collect-strings

    @exterkamp
    exterkamp committed Jul 12, 2019
    Configuration menu
    Copy the full SHA
    ce01c75 View commit details
    Browse the repository at this point in the history

  5. better examples!

    @exterkamp
    exterkamp committed Jul 12, 2019
    Configuration menu
    Copy the full SHA
    dea280a View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2019

  1. correct some complex ICU, add backticks.

    @exterkamp
    exterkamp committed Jul 15, 2019
    Configuration menu
    Copy the full SHA
    7f89ccf View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into placeholders

    @exterkamp
    exterkamp committed Jul 15, 2019
    Configuration menu
    Copy the full SHA
    cf42496 View commit details
    Browse the repository at this point in the history

  3. Update 'yarn update:sample-json' and json itself

    @exterkamp
    exterkamp committed Jul 15, 2019
    Configuration menu
    Copy the full SHA
    d156737 View commit details
    Browse the repository at this point in the history

  4. Handle the TODOs in readme.

    @exterkamp
    exterkamp committed Jul 15, 2019
    Configuration menu
    Copy the full SHA
    89410f8 View commit details
    Browse the repository at this point in the history

  5. Added @Meanings for all duplicated strings.

    @exterkamp
    exterkamp committed Jul 15, 2019
    Configuration menu
    Copy the full SHA
    ea3616b View commit details
    Browse the repository at this point in the history

  6. update sample json

    @exterkamp
    exterkamp committed Jul 15, 2019
    Configuration menu
    Copy the full SHA
    3d40437 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2019

  1. remove from UIStrings, add autofilled meanings + warning log.

    @exterkamp
    exterkamp committed Jul 16, 2019
    Configuration menu
    Copy the full SHA
    bc2b8f3 View commit details
    Browse the repository at this point in the history

  2. Some comments

    @exterkamp
    exterkamp committed Jul 16, 2019
    Configuration menu
    Copy the full SHA
    92cafeb View commit details
    Browse the repository at this point in the history

  3. added TODO to collect-strings

    @exterkamp
    exterkamp committed Jul 16, 2019
    Configuration menu
    Copy the full SHA
    3d746d6 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2019

  1. Merge branch 'master' into placeholders

    @exterkamp
    exterkamp committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    5ad0dff View commit details
    Browse the repository at this point in the history

  2. Paul foodback.

    @exterkamp
    exterkamp committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    c2e4ce5 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2019

  1. Brendan baking foodback part 1.

    @exterkamp
    exterkamp committed Jul 18, 2019
    Configuration menu
    Copy the full SHA
    5dd3e07 View commit details
    Browse the repository at this point in the history

  2. update bakery, and tests. Remove space from yarn clean.

    @exterkamp
    exterkamp committed Jul 18, 2019
    Configuration menu
    Copy the full SHA
    6eef366 View commit details
    Browse the repository at this point in the history

  3. lint

    @exterkamp
    exterkamp committed Jul 18, 2019
    Configuration menu
    Copy the full SHA
    a35a45e View commit details
    Browse the repository at this point in the history

  4. foodback round 2, renaming party.

    @exterkamp
    exterkamp committed Jul 18, 2019
    Configuration menu
    Copy the full SHA
    13d0f02 View commit details
    Browse the repository at this point in the history

  5. Last part of feedback

    @exterkamp
    exterkamp committed Jul 18, 2019
    Configuration menu
    Copy the full SHA
    b34ef95 View commit details
    Browse the repository at this point in the history

  6. windows compat collect-strings handled in appropriate PR.

    @exterkamp
    exterkamp committed Jul 18, 2019
    Configuration menu
    Copy the full SHA
    48283f4 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2019

  1. Brendan foodback part 2.

    @exterkamp
    exterkamp committed Jul 19, 2019
    Configuration menu
    Copy the full SHA
    95527d5 View commit details
    Browse the repository at this point in the history

  2. How'd that var get there.

    @exterkamp
    exterkamp committed Jul 19, 2019
    Configuration menu
    Copy the full SHA
    327c7db View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2019

  1. Brendan feedback v3

    @exterkamp
    exterkamp committed Jul 21, 2019
    Configuration menu
    Copy the full SHA
    b006cf7 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2019

  1. added comment to example fallback.

    @exterkamp
    exterkamp committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    51cbb78 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into placeholders

    @exterkamp
    exterkamp committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    37be64c View commit details
    Browse the repository at this point in the history

  3. complex ICU -> custom-formatted ICU

    @exterkamp
    exterkamp committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    d2a8326 View commit details
    Browse the repository at this point in the history

  4. reorg example logic to directIcu replacement.

    @exterkamp
    exterkamp committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    be426b8 View commit details
    Browse the repository at this point in the history

  5. stop empty plcaeholders from being added to every message. Stricter c… 

    …heck to prevent regression.
    @exterkamp
    exterkamp committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    125cb1d View commit details
    Browse the repository at this point in the history

  6. updated columnName description

    @exterkamp
    exterkamp committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    b95b96b View commit details
    Browse the repository at this point in the history

  7. actually can't assert that in the tests. The undefined part is done a… 

    …fter :(
    @exterkamp
    exterkamp committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    90efcff View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2019

  1. @example {example} varName

    @exterkamp
    exterkamp committed Jul 23, 2019
    Configuration menu
    Copy the full SHA
    6e6ef24 View commit details
    Browse the repository at this point in the history

  2. whoops. console log left in

    @exterkamp
    exterkamp committed Jul 23, 2019
    Configuration menu
    Copy the full SHA
    6a9ef28 View commit details
    Browse the repository at this point in the history

  3. brendan feedback

    @exterkamp
    exterkamp committed Jul 23, 2019
    Configuration menu
    Copy the full SHA
    7762381 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2019

  1. Merge branch 'master' into placeholders

    @exterkamp
    exterkamp committed Jul 24, 2019
    Configuration menu
    Copy the full SHA
    6c19a17 View commit details
    Browse the repository at this point in the history

  2. Add sanity check for ctc files

    @exterkamp
    exterkamp committed Jul 24, 2019
    Configuration menu
    Copy the full SHA
    be34f7e View commit details
    Browse the repository at this point in the history

  3. I feel like my linter is turned off

    @exterkamp
    exterkamp committed Jul 24, 2019
    Configuration menu
    Copy the full SHA
    23a68d5 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into placeholders

    @exterkamp
    exterkamp committed Jul 24, 2019
    Configuration menu
    Copy the full SHA
    3685dd6 View commit details
    Browse the repository at this point in the history