i18n: perf-budget and res-summary column headers #9127
Conversation
exterkamp
requested review from
brendankenny,
patrickhulce and
paulirish
as code owners
exterkamp
changed the title
exterkamp
changed the title
lighthouse-core/lib/i18n/i18n.js
Outdated
| @@ -56,6 +56,12 @@ const UIStrings = { | |||
| columnWastedMs: 'Potential Savings', | |||
| /** Label for the time spent column in data tables, entries will be the number of milliseconds spent during a particular activity */ | |||
| columnTimeSpent: 'Time Spent', | |||
| /** Label for the type of network resource column in data tables, entries will be enumerated kinds of network requests e.g. "Scripts", "Third-Party", "Stylesheet".*/ | |||
There was a problem hiding this comment.
not sure when these descriptions switched formats above, but the ones below (like totalResourceType) seem like they'd read a lot clearer to someone with no context (like, what's a "type of network resource column in data tables"?).
e.g.
Label for a row in a data table; entries will be types of resources loaded over the network, e.g. "Scripts", "Third-Party", "Stylesheet".
seems better
There was a problem hiding this comment.
The ones below are different. Those are rows in the perf-budgets table, not the columns. That's why they're different. But I agree they're more clear.
| @@ -20,6 +20,8 @@ const UIStrings = { | |||
| =1 {1 request} | |||
| other {# requests} | |||
| }`, | |||
| /** Table column header for how displaying how much larger the size of network requests were than a predetermined budget. */ | |||
There was a problem hiding this comment.
| /** Table column header for how displaying how much larger the size of network requests were than a predetermined budget. */ | |
| /** Table column header displaying: how much greater the quantity of network requests were than a predetermined budget, how much larger the size of network requests were than a predetermined budget. */ |
There was a problem hiding this comment.
Integrated this with the column format from i18n.js
Co-Authored-By: Brendan Kenny <[email protected]>
This comment has been minimized.
This comment has been minimized.
|
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Please Googlebot. Please. |
Summary
Noticed this when snooping around for i18n stuff.
fixes: #9126