Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

report: full bleed image thumbnails #9238

Merged
merged 8 commits into from
Jul 20, 2019
Merged

report: full bleed image thumbnails #9238

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c04da53
report: full bleed image thumbnails
paulirish Jun 20, 2019
c07717b
back to img
paulirish Jun 26, 2019
ba492a1
width height
paulirish Jun 27, 2019
c382885
feedback from shane
paulirish Jun 27, 2019
e9b688e
Merge branch 'master' into imgthumbnails
paulirish Jun 27, 2019
78f478d
revert test changes
paulirish Jul 11, 2019
70d227c
alpha sort
paulirish Jul 11, 2019
9099bba
Merge branch 'master' into imgthumbnails
paulirish Jul 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions lighthouse-core/report/html/report-styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@
--header-line-height: 24px;
--highlighter-background-color: var(--report-text-color);
--icon-square-size: calc(var(--score-icon-size) * 0.88);
--image-preview-size: 48px;
--metric-toggle-lines-fill: #7F7F7F;
--metrics-toggle-background-color: var(--color-gray-200);
--plugin-badge-background-color: var(--color-white);
Expand Down Expand Up @@ -208,6 +209,7 @@
--gauge-percentage-font-size: 26px;
--gauge-wrapper-width: 112px;
--header-padding: 16px 0 16px 0;
--image-preview-size: 24px;
--plugin-icon-size: 75%;
--pwa-icon-margin: 0 7px 0 -3px;
--report-font-size: 14px;
Expand Down Expand Up @@ -1300,7 +1302,6 @@
}

.lh-table {
--image-preview-size: 24px;
border-collapse: collapse;
/* Can't assign padding to table, so shorten the width instead. */
width: calc(100% - var(--audit-description-padding-left));
Expand Down Expand Up @@ -1347,8 +1348,10 @@
}


.lh-table-column--thumbnail {
width: calc(var(--image-preview-size) * 2);

.lh-table .lh-table-column--thumbnail {
width: var(--image-preview-size);
padding: 0;
}

.lh-table-column--url {
Expand Down Expand Up @@ -1377,9 +1380,10 @@
}

.lh-thumbnail {
height: var(--image-preview-size);
object-fit: cover;
width: var(--image-preview-size);
object-fit: contain;
height: var(--image-preview-size);
display: block;
}

.lh-text__url > a {
Expand Down