Geolocation audit now returns unknown if page already had granted permission #925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe it's too much? Don't want to spend a ton of time on it though since the report is being redone.
|
ebidel
changed the title
|
The debug boxes look like 💩 . I'm not 😄 with them. Let me tweak a bit, but you guys can look over the code changes. |
|
Sounds good. Can the new stuff be sure to do something with the |
|
Slight update:
I know #926 is in the works so I'll roll out the style changes. |
|
@paulirish removed the report changes. Ready. |
paulirish
approved these changes
Nov 12, 2016
|
|
||
| /* istanbul ignore next */ | ||
| function queryGeolocationPermission() { | ||
| return navigator.permissions.query({name: 'geolocation'}).then(result => { |
There was a problem hiding this comment.
thats very cool. do we need to do a feature detect before using this or are we safe?
There was a problem hiding this comment.
safe. chrome has had the permission api since 43
| @@ -33,6 +33,17 @@ describe('UX: geolocation audit', () => { | |||
| assert.ok(auditResult.debugString); | |||
| }); | |||
|
|
|||
| it('prints debugString information when present', () => { | |||
There was a problem hiding this comment.
"prints debugString info if present in artifact"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @brendankenny @paulirish @GoogleChrome/lighthouse
This also adds
debugStringsupport to the audit if it specifies one: