Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only create a manifest display debugString when there is an error #954

Merged
merged 1 commit into from
Nov 16, 2016

Conversation

brendankenny
Copy link
Member

fixes #933

(taking over for #950 with @ebidel's feedback incorporated)

@brendankenny brendankenny merged commit 9929b90 into master Nov 16, 2016
@brendankenny brendankenny deleted the displaydebug branch November 16, 2016 23:58
andrewrota pushed a commit to andrewrota/lighthouse that referenced this pull request Jan 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manifest display audit shows "should set display property" debugString even if one is set
3 participants