fix(audit/without-javascript): non-string error handling #971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handles the issue with a two-pronged solution. 1. Ensure if `innerText` returns something other than a string to surface the error in the gatherer 2. Ensure the type of the resulting artifact is a string before calling `.trim` Addresses GoogleChrome#967
andrewrota
pushed a commit
to andrewrota/lighthouse
that referenced
this pull request
Jan 13, 2017
…e#971) Handles the issue with a two-pronged solution. 1. Ensure if `innerText` returns something other than a string to surface the error in the gatherer 2. Ensure the type of the resulting artifact is a string before calling `.trim` Addresses GoogleChrome#967
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handles the issue with a two-pronged solution.
innerTextreturns something other than a string to surface the error in the gatherer.trimAddresses #967