-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Set in place of WeakSet #110
Add support for Set in place of WeakSet #110
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
Thanks! |
IE10 does not support Set。 |
IE10 support has ended on January 31, 2020 |
Fixes #104
IE11 does not support WeakSet but does support Set. It is still maintained until Aug 2021.
Since the Weakset is created on import, even when the module is loaded and not executed a breakage is caused.
A plain Set implements the necessary API required by this module.
Error:
ReferenceError: 'WeakSet' is undefined
User agent string:
Mozilla/5.0 (Windows NT 10.0; WOW64; Trident/7.0; rv:11.0) like Gecko
(IE11, Win10)