Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Set in place of WeakSet #110

Merged
merged 2 commits into from
Jan 12, 2021

Conversation

omrilotan
Copy link
Contributor

@omrilotan omrilotan commented Jan 6, 2021

Fixes #104

IE11 does not support WeakSet but does support Set. It is still maintained until Aug 2021.
Since the Weakset is created on import, even when the module is loaded and not executed a breakage is caused.

A plain Set implements the necessary API required by this module.

Error: ReferenceError: 'WeakSet' is undefined
User agent string: Mozilla/5.0 (Windows NT 10.0; WOW64; Trident/7.0; rv:11.0) like Gecko (IE11, Win10)

@google-cla
Copy link

google-cla bot commented Jan 6, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@omrilotan
Copy link
Contributor Author

@googlebot I signed it!

@philipwalton
Copy link
Member

Thanks!

@philipwalton philipwalton merged commit e146cb8 into GoogleChrome:master Jan 12, 2021
This was referenced Mar 12, 2021
@Leo555
Copy link

Leo555 commented Aug 16, 2021

IE10 does not support Set。

@omrilotan
Copy link
Contributor Author

IE10 does not support Set。

IE10 support has ended on January 31, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Internet Explorer 11 Support - WeakSet is undefined
3 participants