Ensure CLS is only reported if page was visible #149
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, in CrUX, CLS will not be reported for a page if it does not report any FCP value. This was done to filter out pages reporting 0 when they were loaded in the background and never focused.
However, matching the CrUX behavior here is problematic for two reasons:
getCLS()
function is coupled to the FCP logic, the final bundle size for those users will be larger than it needs to be for users only interested in the Core Web Vitals.To address both of these points—and anticipate the changes CrUX plans to make—this PR updates the logic to report CLS if the page was ever visible at any point in its lifecycle.