Account for injectManifest replacements in sourcemaps #2239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipwalton
approved these changes
Sep 30, 2019
PR-Bot Size PluginChanged File Sizes
New FilesNo new files have been added. All File SizesView Table
Workbox Aggregate Size Plugin3.51KB gzip'ed (23% of limit) |
steverep
reviewed
Jul 26, 2023
There was a problem hiding this comment.
I filed #3233 thinking there was no support in injectManifest, but I now see the root issues per my comments below. In short, the source map file and reference URL in the new source file will only be correct when swSrc and swDest are in different directories with the same filename, with their corresponding maps in the same folders.
| // See https://github.com/GoogleChrome/workbox/issues/2235 | ||
| if (url) { | ||
| const sourcemapSrcPath = upath.resolve(upath.dirname(options.swSrc), url); | ||
| const sourcemapDestPath = upath.resolve(upath.dirname(options.swDest), url); |
There was a problem hiding this comment.
This will always keep the same source map filename, and if swSrc and swDest are in the same folder, it'll overwrite the original source map file.
Instead, this should just append ".map" to swDest.
|
|
||
| return { | ||
| map: JSON.stringify(updatedSourceMap), | ||
| source: src, |
There was a problem hiding this comment.
This is returned without changing the URL of the source map to reflect the filename in swDest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @philipwalton
Fixes #2235
This was quite a rabbit hole to go down.
Ultimately, I think the code that I ended up with to modify an existing sourcemap to account for the injected manifest does the job, but I would not be shocked if there are some edge cases that I'm not aware of.