feat: Network Intercept: handle special schemes (#1224)

Issue #1183
Spec:
https://w3c.github.io/webdriver-bidi/#match-url-pattern:~:text=If%20scheme%20is%20special%2C%20append%20%22//%22%20to%20pattern%20url.

src/bidiMapper/domains/network/NetworkProcessor.ts

@@ -110,6 +110,9 @@ export class NetworkProcessor {
       switch (urlPattern.type) {
         case 'string': {
           try {
+            // XXX: Switch to URLPattern.
+            // Note: This would require polyfilling as URLPattern is not yet in Node.
+            // https://github.com/nodejs/node/issues/40844
             new URL(urlPattern.pattern);
           } catch (error) {
             throw new InvalidArgumentException(

src/bidiMapper/domains/network/NetworkStorage.spec.ts

@@ -502,4 +502,14 @@ describe('NetworkStorage', () => {
       });
     });
   });
+
+  describe('isSpecialScheme', () => {
+    it('http', () => {
+      expect(NetworkStorage.isSpecialScheme('http')).to.be.true;
+    });
+
+    it('sftp', () => {
+      expect(NetworkStorage.isSpecialScheme('sftp')).to.be.false;
+    });
+  });
 });

src/bidiMapper/domains/network/NetworkStorage.ts

@@ -169,7 +169,9 @@ export class NetworkStorage {
         url += ':';
       }
 
-      url += '//';
+      if (NetworkStorage.isSpecialScheme(protocol)) {
+        url += '//';
+      }
     }
 
     if (hostname) {
@@ -218,6 +220,20 @@ export class NetworkStorage {
     }
   }
 
+  /**
+   * Returns true if the given protocol is special.
+   * Special protocols are those that have a default port.
+   *
+   * Example inputs: 'http', 'http:'
+   *
+   * @see https://url.spec.whatwg.org/#special-scheme
+   */
+  static isSpecialScheme(protocol: string): boolean {
+    return ['ftp', 'file', 'http', 'https', 'ws', 'wss'].includes(
+      protocol.replace(/:$/, '')
+    );
+  }
+
   // XXX: Replace getters with custom operations, follow suit of Browsing Context Storage.
   get blockedRequestMap() {
     return this.#blockedRequestMap;

tests/network/test_add_intercept.py

@@ -166,6 +166,28 @@ async def test_add_intercept_type_pattern_protocol_empty_invalid(websocket):
     } == exception_info.value.args[0]
 
 
+@pytest.mark.asyncio
+async def test_add_intercept_type_pattern_protocol_non_special_success(
+        websocket):
+    result = await execute_command(
+        websocket, {
+            "method": "network.addIntercept",
+            "params": {
+                "phases": ["beforeRequestSent"],
+                "urlPatterns": [{
+                    "type": "pattern",
+                    "protocol": "sftp",
+                    "hostname": "www.example.com",
+                    "port": "22",
+                }],
+            },
+        })
+
+    assert result == {
+        "intercept": ANY_UUID,
+    }
+
+
 @pytest.mark.asyncio
 async def test_add_intercept_type_pattern_hostname_empty_invalid(websocket):
     with pytest.raises(Exception) as exception_info: