feat: wip dpr

GoogleChromeLabs · Oct 12, 2023 · 5a86cd7 · 5a86cd7
1 parent d07ae7a
commit 5a86cd7
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 9 deletions.
diff --git a/src/bidiMapper/domains/context/BrowsingContextImpl.ts b/src/bidiMapper/domains/context/BrowsingContextImpl.ts
@@ -680,7 +680,7 @@ export class BrowsingContextImpl {
 
   async setViewport(
     viewport: BrowsingContext.Viewport | null,
-    devicePixelRatio: number | null
+    devicePixelRatio?: number | null
   ) {
     if (viewport === null && devicePixelRatio === null) {
       await this.#cdpTarget.cdpClient.sendCommand(

diff --git a/src/protocol-parser/webdriver-bidi.ts b/src/protocol-parser/webdriver-bidi.ts
@@ -616,10 +616,7 @@ export namespace BrowsingContext {
     z.object({
       context: BrowsingContext.BrowsingContextSchema,
       viewport: z.union([BrowsingContext.ViewportSchema, z.null()]),
-      devicePixelRatio: z.union([
-        BrowsingContext.DevicePixelRatioSchema,
-        z.null(),
-      ]),
+      devicePixelRatio: z.union([z.number().gt(0), z.null()]).optional(),
     })
   );
 }
@@ -630,7 +627,6 @@ export namespace BrowsingContext {
       height: JsUintSchema,
     })
   );
-  export const DevicePixelRatioSchema = z.lazy(() => z.number().gt(0));
 }
 export namespace BrowsingContext {
   export const ContextCreatedSchema = z.lazy(() =>

diff --git a/src/protocol/webdriver-bidi.ts b/src/protocol/webdriver-bidi.ts
@@ -516,7 +516,7 @@ export namespace BrowsingContext {
   export type SetViewportParameters = {
     context: BrowsingContext.BrowsingContext;
     viewport: BrowsingContext.Viewport | null;
-    devicePixelRatio: number | null;
+    devicePixelRatio?: number | null;
   };
 }
 export namespace BrowsingContext {

diff --git a/tests/browsing_context/test_set_viewport.py b/tests/browsing_context/test_set_viewport.py
@@ -29,7 +29,8 @@ async def test_set_viewport(websocket, context_id, html):
                 "viewport": {
                     "width": 300,
                     "height": 300,
-                }
+                },
+                "devicePixelRatio": None
             }
         })
 
@@ -118,6 +119,7 @@ async def test_set_viewport_unsupported(websocket, context_id, html, width,
                     "viewport": {
                         "width": width,
                         "height": height,
-                    }
+                    },
+                    "devicePixelRatio": None
                 }
             })