fix: catch error when logging args (#2319)

Ref: #2317 I think this should fix it.
GoogleChromeLabs · Jun 14, 2024 · 90b9708 · 90b9708
1 parent 9f5a0d8
commit 90b9708
Showing 1 changed file with 23 additions and 17 deletions.
diff --git a/src/bidiMapper/modules/log/LogManager.ts b/src/bidiMapper/modules/log/LogManager.ts
@@ -118,24 +118,30 @@ export class LogManager {
             );
       for (const browsingContext of realm.associatedBrowsingContexts) {
         this.#eventManager.registerPromiseEvent(
-          argsPromise.then((args) => ({
-            kind: 'success',
-            value: {
-              type: 'event',
-              method: ChromiumBidi.Log.EventNames.LogEntryAdded,
-              params: {
-                level: getLogLevel(params.type),
-                source: realm.source,
-                text: getRemoteValuesText(args, true),
-                timestamp: Math.round(params.timestamp),
-                stackTrace: getBidiStackTrace(params.stackTrace),
-                type: 'console',
-                // Console method is `warn`, not `warning`.
-                method: params.type === 'warning' ? 'warn' : params.type,
-                args,
+          argsPromise.then(
+            (args) => ({
+              kind: 'success',
+              value: {
+                type: 'event',
+                method: ChromiumBidi.Log.EventNames.LogEntryAdded,
+                params: {
+                  level: getLogLevel(params.type),
+                  source: realm.source,
+                  text: getRemoteValuesText(args, true),
+                  timestamp: Math.round(params.timestamp),
+                  stackTrace: getBidiStackTrace(params.stackTrace),
+                  type: 'console',
+                  // Console method is `warn`, not `warning`.
+                  method: params.type === 'warning' ? 'warn' : params.type,
+                  args,
+                },
               },
-            },
-          })),
+            }),
+            (error) => ({
+              kind: 'error',
+              error,
+            })
+          ),
           browsingContext.id,
           ChromiumBidi.Log.EventNames.LogEntryAdded
         );