fix: don't hold in memory finished requests

GoogleChromeLabs · Jul 18, 2023 · cd70fd8 · cd70fd8
1 parent 95e7557
commit cd70fd8
Showing 1 changed file with 16 additions and 4 deletions.
diff --git a/src/bidiMapper/domains/network/networkProcessor.ts b/src/bidiMapper/domains/network/networkProcessor.ts
@@ -98,21 +98,29 @@ export class NetworkProcessor {
       }
     );
 
+    cdpClient.on(
+      'Network.requestServedFromCache',
+      (params: Protocol.Network.RequestServedFromCacheEvent) => {
+        networkProcessor
+          .#getOrCreateNetworkRequest(params.requestId)
+          .onServedFromCache();
+      }
+    );
+
     cdpClient.on(
       'Network.loadingFailed',
       (params: Protocol.Network.LoadingFailedEvent) => {
         networkProcessor
           .#getOrCreateNetworkRequest(params.requestId)
           .onLoadingFailedEvent(params);
+        networkProcessor.#forgetRequest(params.requestId);
       }
     );
 
     cdpClient.on(
-      'Network.requestServedFromCache',
+      'Network.loadingFinished',
       (params: Protocol.Network.RequestServedFromCacheEvent) => {
-        networkProcessor
-          .#getOrCreateNetworkRequest(params.requestId)
-          .onServedFromCache();
+        networkProcessor.#forgetRequest(params.requestId);
       }
     );
 
@@ -125,6 +133,10 @@ export class NetworkProcessor {
     return this.#requestMap.get(requestId);
   }
 
+  #forgetRequest(requestId: Network.Request): void {
+    this.#requestMap.delete(requestId);
+  }
+
   dispose() {
     for (const request of this.#requestMap.values()) {
       request.dispose();