feat: network request: prioritize response status code over extraInfo

Bug: #644
GoogleChromeLabs · Oct 23, 2023 · dd2a229 · dd2a229
1 parent c03051c
commit dd2a229
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/src/bidiMapper/domains/network/NetworkRequest.ts b/src/bidiMapper/domains/network/NetworkRequest.ts
@@ -361,8 +361,8 @@ export class NetworkRequest {
   /** Returns the HTTP status code associated with this request if any. */
   get statusCode(): number {
     return (
-      this.#response.extraInfo?.statusCode ??
       this.#response.info?.response.status ??
+      this.#response.extraInfo?.statusCode ??
       200 // TODO: Throw an exception or use some other status code?
     );
   }

diff --git a/tests/network/test_continue_response.py b/tests/network/test_continue_response.py
@@ -312,7 +312,7 @@ async def test_continue_response_completes_use_cdp_events(
                     },
                 }, ],
                 "url": example_url,
-                "status": 200,  # TODO: Update status code to 501?
+                "status": 501,
                 "statusText": "Remember to drink water",
             }),
             "timestamp": ANY_TIMESTAMP,
@@ -413,7 +413,7 @@ async def test_continue_response_completes_use_bidi_events(
                     },
                 }, ],
                 "url": example_url,
-                "status": 200,  # TODO: Update status code to 501?
+                "status": 501,
                 "statusText": "Remember to drink water",
             }),
             "timestamp": ANY_TIMESTAMP,

diff --git a/tests/network/test_provide_response.py b/tests/network/test_provide_response.py
@@ -273,7 +273,7 @@ async def test_provide_response_completes_use_cdp_events(
                     },
                 }, ],
                 "url": example_url,
-                "status": 200,  # TODO: Update status code to 501?
+                "status": 501,
                 "statusText": "Remember to drink water",
             }),
             "timestamp": ANY_TIMESTAMP,
@@ -379,7 +379,7 @@ async def test_provide_response_completes_use_bidi_events(
                     },
                 }, ],
                 "url": example_url,
-                "status": 200,  # TODO: Update status code to 501?
+                "status": 501,
                 "statusText": "Remember to drink water",
             }),
             "timestamp": ANY_TIMESTAMP,