feat: network request: prioritize response status code over extraInfo #1466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
approved these changes
Oct 23, 2023
thiagowfx
force-pushed
the
thiagowfx/status-code
branch
from
8cca21d
to
dd2a229
Compare
thiagowfx
force-pushed
the
thiagowfx/status-code
branch
6 times, most recently
from
82d5fbf
to
0cfdd2c
Compare
thiagowfx
force-pushed
the
thiagowfx/status-code
branch
from
0cfdd2c
to
fd58313
Compare
|
I set the |
thiagowfx
force-pushed
the
thiagowfx/status-code
branch
from
fd58313
to
2a916b6
Compare
thiagowfx
force-pushed
the
thiagowfx/status-code
branch
from
2a916b6
to
695d8f2
Compare
Lightning00Blade
pushed a commit
that referenced
this pull request
Oct 30, 2023
🤖 I have created a release *beep* *boop* --- ## [0.4.33](chromium-bidi-v0.4.32...chromium-bidi-v0.4.33) (2023-10-30) ### Features * add network intercept continue with auth ([#1470](#1470)) ([ad3a95e](ad3a95e)), closes [#644](#644) * addPreloadScript respects new contexts ([#1478](#1478)) ([b0e55fa](b0e55fa)) * addPreloadScripts respects contexts param for old contexts ([#1475](#1475)) ([0cdde07](0cdde07)) * implement headersSize for network requests ([#1498](#1498)) ([e904ee0](e904ee0)), closes [#644](#644) * implement network interception continue response ([#1443](#1443)) ([4515d1d](4515d1d)), closes [#644](#644) * implement network interception provide response ([#1457](#1457)) ([1eca26e](1eca26e)), closes [#644](#644) * **logging:** pretty print received and sent bidi server messages ([#1490](#1490)) ([45fd24e](45fd24e)) * **network intercept:** implement continue with auth (cont.) ([#1484](#1484)) ([7cc9358](7cc9358)), closes [#644](#644) * **network intercept:** specify BeforeRequestSent whenever AuthRequi… ([#1494](#1494)) ([22eafee](22eafee)), closes [#644](#644) * network request: prioritize response status code over extraInfo ([#1466](#1466)) ([d1f3302](d1f3302)), closes [#644](#644) * **network:** emit `responseStarted` event ("AND") ([#1497](#1497)) ([46220b7](46220b7)), closes [#765](#765) ### Bug Fixes * Add `window.setSelfTargetId` for backward compatibility with chrome driver ([#1461](#1461)) ([fe98f94](fe98f94)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
| this.#response.info?.response.status ?? | ||
| this.#response.extraInfo?.statusCode ?? |
There was a problem hiding this comment.
This is wrong... The extra info has the correct one if we return for example 304 not modified response.
Now it return 200 and brakes Puppeteer test.
We need to find a way to compute which is correct.
There was a problem hiding this comment.
There was a problem hiding this comment.
For network interception, this is correct.
We'll need to add some extra conditions in that method then. If request isBlocked, keep it like this. Otherwise do it the other way around.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: #644