fix: use non-force close for BrowsingContext.close #939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
reviewed
Jul 3, 2023
OrKoN
approved these changes
Jul 3, 2023
Lightning00Blade
force-pushed
the
no-force-close-page
branch
from
3684745
to
2125805
Compare
thiagowfx
reviewed
Jul 3, 2023
thiagowfx
approved these changes
Jul 3, 2023
Lightning00Blade
force-pushed
the
no-force-close-page
branch
2 times, most recently
from
5756ccd
to
6c8ebf9
Compare
thiagowfx
force-pushed
the
no-force-close-page
branch
from
6c8ebf9
to
55dabfb
Compare
Lightning00Blade
force-pushed
the
no-force-close-page
branch
from
55dabfb
to
b40496b
Compare
OrKoN
approved these changes
Jul 4, 2023
thiagowfx
reviewed
Jul 4, 2023
Lightning00Blade
force-pushed
the
no-force-close-page
branch
from
b40496b
to
c0b69e7
Compare
Lightning00Blade
added a commit
that referenced
this pull request
Jul 6, 2023
Recently we changed to use `Page.close` (#939) which does not destroy the target immediately. In puppeteer some times we test timeouts of `1ms` which the command is send and failed on Puppeteer end (never awaited). The problem is we try close the page, but not forcing lets the navigation starting and some NetworkEvents to be sent though CDP, but due to being deferred they never resolve and the ProcessingQueue stops working.
thiagowfx
pushed a commit
that referenced
this pull request
Jul 7, 2023
🤖 I have created a release *beep* *boop* --- ## [0.4.17](chromium-bidi-v0.4.16...chromium-bidi-v0.4.17) (2023-07-07) ### Features * `addScriptToEvaluateOnNewDocument`: run immediately ([#919](#919)) ([cfba71f](cfba71f)) * add Dialog (user prompt) handling ([#924](#924)) ([474a3fa](474a3fa)) * preload scripts: support sandboxes ([#978](#978)) ([ef65951](ef65951)), closes [#293](#293) * protocol: add WindowProxyProperties ([#952](#952)) ([0deef4b](0deef4b)) * prototype network request interception: scaffold protocol ([#845](#845)) ([1b77f94](1b77f94)), closes [#644](#644) * use `maxNodeDepth` + `includeShadowTree` for serialization ([#815](#815)) ([09b4fc6](09b4fc6)) * use generated types for WebDriverBidi ([#961](#961)) ([4f70209](4f70209)) ### Bug Fixes * add stack trace to Unknown errors ([#938](#938)) ([9773a8a](9773a8a)) * Network Module clogging Processing Queue ([#964](#964)) ([9366a5e](9366a5e)) * preload scripts: fully remove optional context param ([#972](#972)) ([e3e7d76](e3e7d76)), closes [#293](#293) [#963](#963) * stop fragmentNavigated from emitting for normal navigation ([#960](#960)) ([7f91b46](7f91b46)), closes [#955](#955) * use non-force close for BrowsingContext.close ([#939](#939)) ([055126f](055126f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BiDi defines that we should run the https://html.spec.whatwg.org/multipage/document-sequences.html#close-a-top-level-traversable, which tells us to run the unload events.
Should we also provide a way to
force closein BiDi spec?