Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement script.addPreloadScript and script.removePreloadScript #293

Closed
19 of 20 tasks
Tracked by #283
sadym-chromium opened this issue Oct 13, 2022 · 3 comments · Fixed by #926, #983 or #985
Closed
19 of 20 tasks
Tracked by #283

Implement script.addPreloadScript and script.removePreloadScript #293

sadym-chromium opened this issue Oct 13, 2022 · 3 comments · Fixed by #926, #983 or #985
Labels
good first issue Good for newcomers implementation
Milestone
[P1] addPreloadSc...

Comments

@sadym-chromium
Copy link
Collaborator

sadym-chromium commented Oct 13, 2022 •
edited by Lightning00Blade
Loading

Implement suggestion in w3c/webdriver-bidi#292, which can be directly mapped to Page.addScriptToEvaluateOnNewDocument.

e2e tests are included in the task.

Out of scope: channels

Tracking
@sadym-chromium sadym-chromium mentioned this issue Oct 13, 2022
Closed
5 tasks
@thiagowfx
Copy link
Contributor

@sadym-chromium sadym-chromium mentioned this issue Mar 20, 2023
Closed
3 tasks
@thiagowfx thiagowfx changed the title Implement script.addLoadScript Implement script.addPreloadScript Mar 24, 2023
thiagowfx pushed a commit that referenced this issue Mar 24, 2023
Scaffold script.addPreloadScript
a6100a8 
Bug: #293
Docs: go/chrome-devtools:bootstrap-bindings-proposal
thiagowfx pushed a commit that referenced this issue Mar 24, 2023
Scaffold script.addPreloadScript
1090f51 
Bug: #293
Docs: go/chrome-devtools:bootstrap-bindings-proposal
Spec: https://w3c.github.io/webdriver-bidi/#command-script-addPreloadScript
thiagowfx pushed a commit that referenced this issue Mar 24, 2023
Scaffold script.addPreloadScript
4bdf791 
Bug: #293
Docs: go/chrome-devtools:bootstrap-bindings-proposal
Spec: https://w3c.github.io/webdriver-bidi/#command-script-addPreloadScript
@thiagowfx thiagowfx mentioned this issue Mar 24, 2023
Merged
thiagowfx pushed a commit that referenced this issue Mar 24, 2023
Scaffold script.addPreloadScript
caa9093 
Bug: #293
Docs: go/chrome-devtools:bootstrap-bindings-proposal
Spec: https://w3c.github.io/webdriver-bidi/#command-script-addPreloadScript
thiagowfx pushed a commit that referenced this issue Mar 24, 2023
Scaffold script.addPreloadScript
9e4d6b2 
Bug: #293
Docs: go/chrome-devtools:bootstrap-bindings-proposal
Spec: https://w3c.github.io/webdriver-bidi/#command-script-addPreloadScript
thiagowfx pushed a commit that referenced this issue Mar 24, 2023
Scaffold script.addPreloadScript
dcd2883 
Bug: #293
Docs: go/chrome-devtools:bootstrap-bindings-proposal
Spec: https://w3c.github.io/webdriver-bidi/#command-script-addPreloadScript
thiagowfx pushed a commit that referenced this issue Mar 24, 2023
Scaffold script.addPreloadScript
2be7219 
Bug: #293
Docs: go/chrome-devtools:bootstrap-bindings-proposal
Spec: https://w3c.github.io/webdriver-bidi/#command-script-addPreloadScript
thiagowfx pushed a commit that referenced this issue Mar 24, 2023
Scaffold script.addPreloadScript
ea1590d 
Bug: #293
Docs: go/chrome-devtools:bootstrap-bindings-proposal
Spec: https://w3c.github.io/webdriver-bidi/#command-script-addPreloadScript
thiagowfx pushed a commit that referenced this issue Mar 24, 2023
Scaffold script.addPreloadScript
abb5a78 
Bug: #293
Docs: go/chrome-devtools:bootstrap-bindings-proposal
Spec: https://w3c.github.io/webdriver-bidi/#command-script-addPreloadScript
thiagowfx pushed a commit that referenced this issue Mar 24, 2023
Scaffold script.addPreloadScript
c270efa 
Bug: #293
Docs: go/chrome-devtools:bootstrap-bindings-proposal
Spec: https://w3c.github.io/webdriver-bidi/#command-script-addPreloadScript
thiagowfx pushed a commit that referenced this issue Mar 24, 2023
Scaffold script.addPreloadScript
da0dcff 
Bug: #293
Docs: go/chrome-devtools:bootstrap-bindings-proposal
Spec: https://w3c.github.io/webdriver-bidi/#command-script-addPreloadScript
thiagowfx pushed a commit that referenced this issue Mar 24, 2023
Scaffold script.addPreloadScript
1a0bf3a 
Bug: #293
Docs: go/chrome-devtools:bootstrap-bindings-proposal
Spec: https://w3c.github.io/webdriver-bidi/#command-script-addPreloadScript
thiagowfx pushed a commit that referenced this issue Mar 24, 2023
Scaffold script.addPreloadScript
05bd407 
Bug: #293
Docs: go/chrome-devtools:bootstrap-bindings-proposal
Spec: https://w3c.github.io/webdriver-bidi/#command-script-addPreloadScript
thiagowfx pushed a commit that referenced this issue Mar 24, 2023
Scaffold script.addPreloadScript
9d02c2b 
Bug: #293
Docs: go/chrome-devtools:bootstrap-bindings-proposal
Spec: https://w3c.github.io/webdriver-bidi/#command-script-addPreloadScript
thiagowfx pushed a commit that referenced this issue Mar 27, 2023
Scaffold script.addPreloadScript
1fcfd9b 
Bug: #293
Docs: go/chrome-devtools:bootstrap-bindings-proposal
Spec: https://w3c.github.io/webdriver-bidi/#command-script-addPreloadScript
thiagowfx pushed a commit that referenced this issue Mar 27, 2023
Scaffold script.addPreloadScript
879c8ad 
Bug: #293
Docs: go/chrome-devtools:bootstrap-bindings-proposal
Spec: https://w3c.github.io/webdriver-bidi/#command-script-addPreloadScript
thiagowfx pushed a commit that referenced this issue Mar 27, 2023
Scaffold script.addPreloadScript
4b35d3b 
Bug: #293
Docs: go/chrome-devtools:bootstrap-bindings-proposal
Spec: https://w3c.github.io/webdriver-bidi/#command-script-addPreloadScript
thiagowfx pushed a commit that referenced this issue Mar 27, 2023
Scaffold script.addPreloadScript
52e2462 
Bug: #293
Docs: go/chrome-devtools:bootstrap-bindings-proposal
Spec: https://w3c.github.io/webdriver-bidi/#command-script-addPreloadScript
thiagowfx pushed a commit that referenced this issue Mar 27, 2023
Scaffold script.addPreloadScript
8eec22c 
Bug: #293
Docs: go/chrome-devtools:bootstrap-bindings-proposal
Spec: https://w3c.github.io/webdriver-bidi/#command-script-addPreloadScript
thiagowfx pushed a commit that referenced this issue Mar 27, 2023
Scaffold script.addPreloadScript
8c747d1 
Bug: #293
Docs: go/chrome-devtools:bootstrap-bindings-proposal
Spec: https://w3c.github.io/webdriver-bidi/#command-script-addPreloadScript
thiagowfx pushed a commit that referenced this issue Mar 27, 2023
Scaffold script.addPreloadScript
d83663f 
Bug: #293
Docs: go/chrome-devtools:bootstrap-bindings-proposal
Spec: https://w3c.github.io/webdriver-bidi/#command-script-addPreloadScript
thiagowfx pushed a commit that referenced this issue Jul 6, 2023
fix: preload scripts: fully remove optional context param
e7181b4 
Effectively treat all preload scripts as top-level.

Bug: #293
Follow-up-of: #963
thiagowfx pushed a commit that referenced this issue Jul 6, 2023
feat: addScriptToEvaluateOnNewDocument: run immediately
76ec14a 
Bug: #293
Doc: go/chrome-devtools:preload-script-world-name

chore: remove Runtime.evaluate for preload scripts
thiagowfx pushed a commit that referenced this issue Jul 6, 2023
fix: preload scripts: fully remove optional context param (#972)
e3e7d76 
Effectively treat all preload scripts as top-level.

Bug: #293
Follow-up-of: #963
@release-please release-please bot mentioned this issue Jul 6, 2023
Merged
thiagowfx pushed a commit that referenced this issue Jul 6, 2023
feat: addScriptToEvaluateOnNewDocument: run immediately
e0799ad 
Bug: #293
Doc: go/chrome-devtools:preload-script-world-name

chore: remove Runtime.evaluate for preload scripts
thiagowfx pushed a commit that referenced this issue Jul 6, 2023
feat: addScriptToEvaluateOnNewDocument: run immediately
2fff598 
Bug: #293
Doc: go/chrome-devtools:preload-script-world-name

chore: remove Runtime.evaluate for preload scripts
thiagowfx pushed a commit that referenced this issue Jul 6, 2023
feat: addScriptToEvaluateOnNewDocument: run immediately
9263136 
Bug: #293
Doc: go/chrome-devtools:preload-script-world-name

chore: remove Runtime.evaluate for preload scripts
thiagowfx pushed a commit that referenced this issue Jul 6, 2023
feat: addScriptToEvaluateOnNewDocument: run immediately (#919)
cfba71f 
Bug: #293
Doc:
[go/chrome-devtools:preload-script-world-name](http://go/chrome-devtools:preload-script-world-name)

## Tracking

- [x] Blocked on
#885
thiagowfx pushed a commit that referenced this issue Jul 6, 2023
test: preload scripts: add e2e test with user gesture
45b87c4 
Bug: #293
thiagowfx pushed a commit that referenced this issue Jul 6, 2023
@sadym-chromium
test: preload scripts: add e2e test with user gesture
bee3a64 
Bug: #293
Co-authored-by: Maksim Sadym <[email protected]>
Reland-of: #752 (revert: #879)
thiagowfx pushed a commit that referenced this issue Jul 6, 2023
feat: preload scripts: support sandboxes
b3b6521 
Bug: #293
Docs: go/chrome-devtools:preload-script-world-name
@thiagowfx thiagowfx mentioned this issue Jul 6, 2023
Merged
thiagowfx pushed a commit that referenced this issue Jul 6, 2023
feat: preload scripts: support sandboxes
9641dfe 
Bug: #293
Docs: go/chrome-devtools:preload-script-world-name
thiagowfx pushed a commit that referenced this issue Jul 6, 2023
feat: preload scripts: support sandboxes
f9c750e 
Bug: #293
Docs: go/chrome-devtools:preload-script-world-name
OrKoN pushed a commit that referenced this issue Jul 7, 2023
@OrKoN
feat: preload scripts: support sandboxes
6f569fc 
Bug: #293
Docs: go/chrome-devtools:preload-script-world-name
OrKoN pushed a commit that referenced this issue Jul 7, 2023
@OrKoN
feat: preload scripts: support sandboxes
2c591c4 
Bug: #293
Docs: go/chrome-devtools:preload-script-world-name
OrKoN pushed a commit that referenced this issue Jul 7, 2023
feat: preload scripts: support sandboxes (#978)
ef65951 
Bug: #293
Docs: go/chrome-devtools:preload-script-world-name
thiagowfx pushed a commit that referenced this issue Jul 7, 2023
@sadym-chromium
test: preload scripts: add e2e test with user gesture
e4c9776 
Bug: #293
Co-authored-by: Maksim Sadym <[email protected]>
Reland-of: #752 (revert: #879)
@thiagowfx thiagowfx mentioned this issue Jul 7, 2023
Merged
thiagowfx pushed a commit that referenced this issue Jul 7, 2023
@sadym-chromium
test: preload scripts: add e2e test with user gesture
27aeda4 
Bug: #293
Co-authored-by: Maksim Sadym <[email protected]>
Reland-of: #752 (revert: #879)
thiagowfx pushed a commit that referenced this issue Jul 7, 2023
@sadym-chromium
test: preload scripts: add e2e test with user gesture (#983)
d3fc4cf 
Closes: #293
Reland-of: #752 (revert: #879)

---------

Co-authored-by: Maksim Sadym <[email protected]>
thiagowfx pushed a commit that referenced this issue Jul 7, 2023
docs: add preload script example
ab98471 
Closes: #293
@thiagowfx thiagowfx mentioned this issue Jul 7, 2023
Merged
thiagowfx pushed a commit that referenced this issue Jul 7, 2023
docs: add preload script example (#985)
1abd52d 
This closes the preload script milestone:
https://github.com/GoogleChromeLabs/chromium-bidi/milestone/15

Closes: #293
thiagowfx pushed a commit that referenced this issue Jul 7, 2023
@release-please
chore(main): release chromium-bidi 0.4.17 (#926)
8c229b0 
🤖 I have created a release *beep* *boop*
---


##
[0.4.17](chromium-bidi-v0.4.16...chromium-bidi-v0.4.17)
(2023-07-07)


### Features

* `addScriptToEvaluateOnNewDocument`: run immediately
([#919](#919))
([cfba71f](cfba71f))
* add Dialog (user prompt) handling
([#924](#924))
([474a3fa](474a3fa))
* preload scripts: support sandboxes
([#978](#978))
([ef65951](ef65951)),
closes
[#293](#293)
* protocol: add WindowProxyProperties
([#952](#952))
([0deef4b](0deef4b))
* prototype network request interception: scaffold protocol
([#845](#845))
([1b77f94](1b77f94)),
closes
[#644](#644)
* use `maxNodeDepth` + `includeShadowTree` for serialization
([#815](#815))
([09b4fc6](09b4fc6))
* use generated types for WebDriverBidi
([#961](#961))
([4f70209](4f70209))


### Bug Fixes

* add stack trace to Unknown errors
([#938](#938))
([9773a8a](9773a8a))
* Network Module clogging Processing Queue
([#964](#964))
([9366a5e](9366a5e))
* preload scripts: fully remove optional context param
([#972](#972))
([e3e7d76](e3e7d76)),
closes
[#293](#293)
[#963](#963)
* stop fragmentNavigated from emitting for normal navigation
([#960](#960))
([7f91b46](7f91b46)),
closes
[#955](#955)
* use non-force close for BrowsingContext.close
([#939](#939))
([055126f](055126f))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
@thiagowfx thiagowfx removed their assignment Nov 23, 2023
@Lightning00Blade
Copy link
Collaborator

Lightning00Blade commented Aug 8, 2024 •
edited
Loading

Closing the Umbrella bug the left issue will be track on its separate bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers implementation
Projects
None yet
Milestone
[P1] addPreloadScript (formerly boots...
4 participants
@thiagowfx @Lightning00Blade @sadym-chromium @jrandolf-2