Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: replace empty string namespaceURI with null #1285

Merged
merged 3 commits into from
Sep 12, 2023
Merged

fix: replace empty string namespaceURI with null #1285

merged 3 commits into from
Sep 12, 2023

Conversation

sadym-chromium
Copy link
Collaborator

@sadym-chromium sadym-chromium commented Sep 12, 2023 •
edited
Loading

Temp fix before the CDP fix is landed

Lightning00Blade
Lightning00Blade approved these changes Sep 12, 2023
View reviewed changes
Copy link
Collaborator

@Lightning00Blade Lightning00Blade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WPT needs updated expectations.

@sadym-chromium sadym-chromium merged commit 93fdf47 into main Sep 12, 2023
16 checks passed
@sadym-chromium sadym-chromium deleted the sadym/attributeNamespaceURI branch September 12, 2023 13:23
@release-please release-please bot mentioned this pull request Sep 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lightning00Blade Lightning00Blade Lightning00Blade approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sadym-chromium @Lightning00Blade