fix: automatically continue ignored events #1528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiagowfx
reviewed
Nov 7, 2023
thiagowfx
reviewed
Nov 7, 2023
thiagowfx
approved these changes
Nov 7, 2023
sadym-chromium
approved these changes
Nov 8, 2023
|
Q: why do we ignore favicon? |
Lightning00Blade
force-pushed
the
continue-ignored-events
branch
from
27dd7a4
to
55318ec
Compare
|
@OrKoN If I recall correctly WPT test don't expect whose request/response and will fail assertions, and due to them firing at different time test will become very flaky. |
Lightning00Blade
pushed a commit
that referenced
this pull request
Nov 15, 2023
🤖 I have created a release *beep* *boop* --- ## [0.4.34](chromium-bidi-v0.4.33...chromium-bidi-v0.4.34) (2023-11-15) ### Features * abort navigation if network request failed ([#1542](#1542)) ([2f86ba0](2f86ba0)) * context close to support promptUnload ([#1508](#1508)) ([45a2100](45a2100)) * implement browsingContext.traverseHistory ([#1537](#1537)) ([76ca291](76ca291)) * make `internalId` `UUID` ([#1525](#1525)) ([8b108ce](8b108ce)) * **network intercept:** populate "intercepts" in base event params ([#1500](#1500)) ([55d1622](55d1622)) ### Bug Fixes * allow interception for all requests ([#1530](#1530)) ([ec3fce9](ec3fce9)) * automatically continue ignored events ([#1528](#1528)) ([8d92718](8d92718)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we ignore
favicon.icorequest. We should not block them for interception.