fix: emit network.responseCompleted for redirects
#2098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
approved these changes
Apr 2, 2024
Lightning00Blade
force-pushed
the
emit-completed-for-redirects
branch
from
6c6a497
to
195b055
Compare
Lightning00Blade
pushed a commit
that referenced
this pull request
Apr 10, 2024
🤖 I have created a release *beep* *boop* --- ## [0.5.17](chromium-bidi-v0.5.16...chromium-bidi-v0.5.17) (2024-04-10) ### Features * **network:** support more props for `initiator` ([#2115](#2115)) ([80dd9e6](80dd9e6)) ### Bug Fixes * **browsingContext:** emit `navigationFailed` for `navigate` command failure ([#2118](#2118)) ([382a762](382a762)) * don't expect interception for cached events ([#2087](#2087)) ([063c1d1](063c1d1)) * emit `network.responseCompleted` for redirects ([#2098](#2098)) ([219cfc9](219cfc9)) * **network:** support Interception for OOPIF ([#2110](#2110)) ([5d0845c](5d0845c)) * **script:** support PreloadScript in OOPIF ([#2109](#2109)) ([baa263e](baa263e)) * sending undefined viewport should keep previously set viewport ([#2119](#2119)) ([823e52d](823e52d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we never await the
responseReceivedExtraInfoas we destroy the BiDiNetworkRequestas soon as we see the redirect happening. This means that the conditions for emitting are never met.We should eventually change this but having the
responseCompletedevent with missing headers is better then not having it at all.Such change would mean that can never have order that matches the expectations
beforeRequestSent->responseCompleted->beforeRequestSentAs the
responseReceivedExtraInfocomes after the second CDPrequestWillBeSent#2035