Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix "too much recursion" when parsing large bundle #155

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

z8po
Copy link

@z8po z8po commented Mar 7, 2024

On large css bundle the regexp used in applyTargetTextStyle for parsing css makes firefox hang seconds then throws an "Uncaught InternalError: too much recursion". This fix optimize the regexp by removing useless capture group and replace usefull ones by non capturing group.

On large css bundle the regexp used in applyTargetTextStyle for parsing css makes firefox hang seconds then throws an "Uncaught InternalError: too much recursion".
This fix optimize the regexp by removing useless capture group and replace usefull ones by non capturing group.
Copy link

google-cla bot commented Mar 7, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@tomayac
Copy link
Member

tomayac commented Mar 7, 2024

Thank you, this looks great! Only thing missing is signing the CLA before this can be merged.

@tomayac
Copy link
Member

tomayac commented Mar 13, 2024

@z8po Friendly ping regarding the CLA signature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants