upgrade java-storage #1001
Merged
upgrade java-storage #1001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1001 +/- ##
============================================
+ Coverage 76.47% 82.30% +5.83%
- Complexity 1637 1780 +143
============================================
Files 101 101
Lines 7949 7953 +4
Branches 995 996 +1
============================================
+ Hits 6079 6546 +467
+ Misses 1425 1007 -418
+ Partials 445 400 -45
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
abmodi
approved these changes
May 19, 2023
medb
approved these changes
May 19, 2023
singhravidutt
added a commit
that referenced
this pull request
May 20, 2023
singhravidutt
added a commit
that referenced
this pull request
May 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In relation to directPath support issue in cloudBuild #956, added an ENV variable to control it.
Currently in cloudBuild gRPC calls generated via java-storage were going GFE silently as directPath wasn't supported. With new version of the java-storage v2.22.2 it will fail if DirectPath is opted.
With
GCS_TEST_DIRECT_PATH_PREFERREDwe will be able to control the integration test cases.