Update Kubernetes dependencies to release branch #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the dependency toml to all use the release branches of the Kubernetes libraries. Also changes the build image to use the release-1.8 branch of the code-generator Kuebrnetes repository, now that it hsa vendored dependencies. Closes #1
markmandel
added
area/build-tools
zmerlynn
added a commit
to zmerlynn/agones
that referenced
this pull request
Apr 24, 2023
When the fleet tests flake, they take out the rest of the test suite: ``` Step googleforgames#24 - "submit-e2e-test-cloud-build": gke-autopilot-1.24: Step googleforgames#2 - "e2e-stable": VERBOSE: --- FAIL: TestFleetScaleUpAllocateEditAndScaleDownToZero (163.39s) Step googleforgames#24 - "submit-e2e-test-cloud-build": gke-autopilot-1.24: Step googleforgames#2 - "e2e-stable": VERBOSE: panic: runtime error: index out of range [0] with length 0 [recovered] Step googleforgames#24 - "submit-e2e-test-cloud-build": gke-autopilot-1.24: Step googleforgames#2 - "e2e-stable": VERBOSE: panic: runtime error: index out of range [0] with length 0 ``` Looking at this file, it's easy to see why: if there's every an error from any of these asserts, we just continue with the test and assume the fleet is valid. But it's not.
zmerlynn
added a commit
to zmerlynn/agones
that referenced
this pull request
Apr 24, 2023
When the fleet tests flake, they take out the rest of the test suite: ``` Step googleforgames#24 - "submit-e2e-test-cloud-build": gke-autopilot-1.24: Step googleforgames#2 - "e2e-stable": VERBOSE: --- FAIL: TestFleetScaleUpAllocateEditAndScaleDownToZero (163.39s) Step googleforgames#24 - "submit-e2e-test-cloud-build": gke-autopilot-1.24: Step googleforgames#2 - "e2e-stable": VERBOSE: panic: runtime error: index out of range [0] with length 0 [recovered] Step googleforgames#24 - "submit-e2e-test-cloud-build": gke-autopilot-1.24: Step googleforgames#2 - "e2e-stable": VERBOSE: panic: runtime error: index out of range [0] with length 0 ``` Looking at this file, it's easy to see why: if there's every an error from any of these asserts, we just continue with the test and assume the fleet is valid. But it's not.
zmerlynn
added a commit
that referenced
this pull request
Apr 24, 2023
* require.NoError in fleet tests instead of continuing When the fleet tests flake, they take out the rest of the test suite: ``` Step #24 - "submit-e2e-test-cloud-build": gke-autopilot-1.24: Step #2 - "e2e-stable": VERBOSE: --- FAIL: TestFleetScaleUpAllocateEditAndScaleDownToZero (163.39s) Step #24 - "submit-e2e-test-cloud-build": gke-autopilot-1.24: Step #2 - "e2e-stable": VERBOSE: panic: runtime error: index out of range [0] with length 0 [recovered] Step #24 - "submit-e2e-test-cloud-build": gke-autopilot-1.24: Step #2 - "e2e-stable": VERBOSE: panic: runtime error: index out of range [0] with length 0 ``` Looking at this file, it's easy to see why: if there's every an error from any of these asserts, we just continue with the test and assume the fleet is valid. But it's not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the dependency toml to all use the release branches
of the Kubernetes libraries.
Also changes the build image to use the release-1.8 branch
of the code-generator Kuebrnetes repository, now that
it hsa vendored dependencies.
Closes #1