Skip to content

Commit

Permalink
require.NoError in fleet tests instead of continuing (#3124)
Browse files Browse the repository at this point in the history
* require.NoError in fleet tests instead of continuing

When the fleet tests flake, they take out the rest of the test suite:

```
Step #24 - "submit-e2e-test-cloud-build": gke-autopilot-1.24: Step #2 - "e2e-stable": VERBOSE: --- FAIL: TestFleetScaleUpAllocateEditAndScaleDownToZero (163.39s)
Step #24 - "submit-e2e-test-cloud-build": gke-autopilot-1.24: Step #2 - "e2e-stable": VERBOSE: panic: runtime error: index out of range [0] with length 0 [recovered]
Step #24 - "submit-e2e-test-cloud-build": gke-autopilot-1.24: Step #2 - "e2e-stable": VERBOSE:     panic: runtime error: index out of range [0] with length 0
```

Looking at this file, it's easy to see why: if there's every an error
from any of these asserts, we just continue with the test and assume
the fleet is valid. But it's not.
  • Loading branch information
zmerlynn authored Apr 24, 2023
1 parent 15411ae commit b22ec70
Showing 1 changed file with 65 additions and 75 deletions.
Loading

0 comments on commit b22ec70

Please sign in to comment.