make gcloud-auth-docker works on Windows
#50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue was that the code attempted to mount /tmp with Docker. On Windows, the mount path has to be from /c (or another root dir), otherwise it won't work. Doing the temporary work in a `tmp` directory under the `build` dir solved the issue. Closes #49
markmandel
added
area/build-tools
cyriltovena
approved these changes
Jan 7, 2018
| mkdir -p $(build_path)/tmp/gcloud-auth-docker | ||
| -cp ~/.dockercfg $(build_path)/tmp/gcloud-auth-docker | ||
| docker run --rm $(common_mounts) -v $(build_path)/tmp/gcloud-auth-docker:/root $(build_tag) gcloud docker --authorize-only | ||
| sudo mv $(build_path)/tmp/gcloud-auth-docker/.dockercfg ~/ |
There was a problem hiding this comment.
ha yes you're right this is the WSL docker cli my bad in the issue I got confused with the windows one.
There was a problem hiding this comment.
Heh 😆
Turtles all the way down! 🐢
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue was that the code attempted to mount /tmp with Docker. On Windows, the mount path has to be
from /c (or another root dir), otherwise it won't work. Doing the temporary work in a
tmpdirectoryunder the
builddir solved the issue.Closes #49
/cc @Kuqd