Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make gcloud-auth-docker works on Windows #50

Merged
merged 1 commit into from
Jan 7, 2018
Merged

make gcloud-auth-docker works on Windows #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,5 @@
!.gitignore
*.iml
bin
*.o
*.o
tmp
10 changes: 5 additions & 5 deletions build/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,11 +219,11 @@ gcloud-auth-cluster: ensure-build-image
# authenticate our docker configuration so that you can do a docker push directly
# to the gcr.io repository
gcloud-auth-docker: ensure-build-image
-sudo rm -rf /tmp/gcloud-auth-docker
mkdir -p /tmp/gcloud-auth-docker
-cp ~/.dockercfg /tmp/gcloud-auth-docker
docker run --rm $(common_mounts) -v /tmp/gcloud-auth-docker:/root --entrypoint="gcloud" $(build_tag) docker --authorize-only
sudo mv /tmp/gcloud-auth-docker/.dockercfg ~/
-sudo rm -rf $(build_path)/tmp
mkdir -p $(build_path)/tmp/gcloud-auth-docker
-cp ~/.dockercfg $(build_path)/tmp/gcloud-auth-docker
docker run --rm $(common_mounts) -v $(build_path)/tmp/gcloud-auth-docker:/root $(build_tag) gcloud docker --authorize-only
sudo mv $(build_path)/tmp/gcloud-auth-docker/.dockercfg ~/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ha yes you're right this is the WSL docker cli my bad in the issue I got confused with the windows one.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh 😆

Turtles all the way down! 🐢

sudo chown $(USER) ~/.dockercfg

# Clean the gcloud configuration
Expand Down