-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pre-commit.ci] pre-commit autoupdate #307
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Testing this results in this error right now:
Working on debugging this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nbqa requires a python version >=3.8.0. But the dlvm that Vertex uses for the instance we currently use (tensorflow 2.8) uses python version 3.7.12
. So the installation of nbqa fails. My suggestion is to wait to till the dlvm python version has been updated to >=3.8.0 before merging this update.
Converted this to draft so far. |
Partially updated only isort package to the hotfix version that runs on Python 3.7. #322 |
253a215
to
cdb3b43
Compare
Now Vertex AI workbench Python version is updated to 3.10.0! |
cdb3b43
to
6b3a28e
Compare
6b3a28e
to
8541fe5
Compare
8541fe5
to
467ed63
Compare
updates: - [github.com/pre-commit/pre-commit-hooks: v4.3.0 → v4.5.0](pre-commit/pre-commit-hooks@v4.3.0...v4.5.0) - [github.com/nbQA-dev/nbQA: 1.5.2 → 1.7.1](nbQA-dev/nbQA@1.5.2...1.7.1) - [github.com/PyCQA/isort: 5.11.5 → 5.13.2](PyCQA/isort@5.11.5...5.13.2) - [github.com/psf/black: 22.8.0 → 23.12.1](psf/black@22.8.0...23.12.1) - [github.com/asottile/pyupgrade: v2.38.2 → v3.15.0](asottile/pyupgrade@v2.38.2...v3.15.0) - [github.com/pycqa/pylint: v2.15.3 → v3.0.3](pylint-dev/pylint@v2.15.3...v3.0.3)
467ed63
to
1a90c13
Compare
Rebased on master branch |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for taking care of this
updates: