Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pre-commit.ci] pre-commit autoupdate #307

Merged
merged 4 commits into from
Mar 5, 2024

Conversation

@google-cla
Copy link

google-cla bot commented Jan 2, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@sanjanalreddy sanjanalreddy self-requested a review January 5, 2023 01:26
@sanjanalreddy
Copy link
Collaborator

Testing this results in this error right now:

An unexpected error has occurred: CalledProcessError: command: ('/home/jupyter/.cache/pre-commit/repojnsa75y8/py_env-python3/bin/python', '-mpip', 'install', '.', 'black')
return code: 1
stdout:
    Processing /home/jupyter/.cache/pre-commit/repojnsa75y8
      Installing build dependencies: started
      Installing build dependencies: finished with status 'done'
      Getting requirements to build wheel: started
      Getting requirements to build wheel: finished with status 'done'
      Preparing metadata (pyproject.toml): started
      Preparing metadata (pyproject.toml): finished with status 'done'
    Collecting black
      Downloading black-22.12.0-cp37-cp37m-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (1.5 MB)
         ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 1.5/1.5 MB 28.8 MB/s eta 0:00:00
    Collecting tokenize-rt>=3.2.0
      Downloading tokenize_rt-5.0.0-py2.py3-none-any.whl (5.8 kB)
    Collecting tomli
      Using cached tomli-2.0.1-py3-none-any.whl (12 kB)
    Collecting ipython>=7.8.0
      Downloading ipython-7.34.0-py3-none-any.whl (793 kB)
         ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 793.8/793.8 kB 67.8 MB/s eta 0:00:00
    
stderr:
    ERROR: Package 'nbqa' requires a different Python: 3.7.12 not in '>=3.8.0'

Working on debugging this.

Copy link
Collaborator

@sanjanalreddy sanjanalreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nbqa requires a python version >=3.8.0. But the dlvm that Vertex uses for the instance we currently use (tensorflow 2.8) uses python version 3.7.12. So the installation of nbqa fails. My suggestion is to wait to till the dlvm python version has been updated to >=3.8.0 before merging this update.

@BenoitDherin @takumiohym @kylesteckler

@sanjanalreddy sanjanalreddy self-assigned this Jan 5, 2023
@takumiohym takumiohym marked this pull request as draft January 23, 2023 20:09
@takumiohym
Copy link
Collaborator

Converted this to draft so far.

@takumiohym
Copy link
Collaborator

takumiohym commented Jan 31, 2023

Partially updated only isort package to the hotfix version that runs on Python 3.7. #322

@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 253a215 to cdb3b43 Compare April 4, 2023 02:57
@takumiohym
Copy link
Collaborator

Now Vertex AI workbench Python version is updated to 3.10.0!

@takumiohym takumiohym marked this pull request as ready for review May 30, 2023 08:23
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from cdb3b43 to 6b3a28e Compare July 4, 2023 02:45
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 6b3a28e to 8541fe5 Compare October 3, 2023 05:46
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 8541fe5 to 467ed63 Compare January 1, 2024 19:23
updates:
- [github.com/pre-commit/pre-commit-hooks: v4.3.0 → v4.5.0](pre-commit/pre-commit-hooks@v4.3.0...v4.5.0)
- [github.com/nbQA-dev/nbQA: 1.5.2 → 1.7.1](nbQA-dev/nbQA@1.5.2...1.7.1)
- [github.com/PyCQA/isort: 5.11.5 → 5.13.2](PyCQA/isort@5.11.5...5.13.2)
- [github.com/psf/black: 22.8.0 → 23.12.1](psf/black@22.8.0...23.12.1)
- [github.com/asottile/pyupgrade: v2.38.2 → v3.15.0](asottile/pyupgrade@v2.38.2...v3.15.0)
- [github.com/pycqa/pylint: v2.15.3 → v3.0.3](pylint-dev/pylint@v2.15.3...v3.0.3)
@takumiohym
Copy link
Collaborator

Rebased on master branch

@takumiohym
Copy link
Collaborator

takumiohym commented Mar 1, 2024

Copy link
Collaborator

@sanjanalreddy sanjanalreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for taking care of this

@takumiohym takumiohym merged commit 1008d5a into master Mar 5, 2024
4 of 5 checks passed
@takumiohym takumiohym deleted the pre-commit-ci-update-config branch March 5, 2024 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants