XAI with Saliency library solution notebook #426

takumiohym · 2024-03-14T18:55:07Z

A new notebook for XAI with Saliency library. This notebook trains and explains a image classification model locally.

review-notebook-app · 2024-03-14T18:55:13Z

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

review-notebook-app · 2024-03-25T22:06:06Z

View / edit / reply to this conversation on ReviewNB

sanjanalreddy commented on 2024-03-25T22:06:05Z
----------------------------------------------------------------

Can you add a line about what the Saliency library does?

takumiohym commented on 2024-03-27T16:43:21Z
----------------------------------------------------------------

Makes sense! Added.

review-notebook-app · 2024-03-25T22:06:06Z

View / edit / reply to this conversation on ReviewNB

sanjanalreddy commented on 2024-03-25T22:06:06Z
----------------------------------------------------------------

Can you please break these functions up into multiple cells and provide an explanation of what each function does?

takumiohym commented on 2024-03-27T16:50:50Z
----------------------------------------------------------------

Actually this cell and description is taken by the vertex ai explanation notebook.

https://github.com/GoogleCloudPlatform/asl-ml-immersion/blob/master/notebooks/responsible_ai/explainable_ai/solutions/xai_image_vertex.ipynb

I think we can assume the user understand this basic flows as the vertex ai version assumes in this notebook, since it is not the focus.

Anyway I added a reference to another notebook in case students want to review what's going on here. I hope it helps!

BenoitDherin commented on 2024-03-28T16:08:55Z
----------------------------------------------------------------

I agree with Sanjana. Breaking that long code cell and adding one-liner explanations in markdown will help a lot.

takumiohym commented on 2024-04-02T19:50:51Z
----------------------------------------------------------------

Broke up to multiple cells, and removed unnecessary functions.

review-notebook-app · 2024-03-25T22:06:07Z

View / edit / reply to this conversation on ReviewNB

sanjanalreddy commented on 2024-03-25T22:06:07Z
----------------------------------------------------------------

Line #36.            "https://tfhub.dev/google/imagenet/"

tfhub.dev is going to be deprecated soon, can you use the Kaggle Models link here instead?

takumiohym commented on 2024-03-27T16:53:35Z
----------------------------------------------------------------

Makes sense! Updated.

BenoitDherin commented on 2024-03-28T16:12:53Z
----------------------------------------------------------------

Please store the long URL into a separate variable at the beginning of the cell.

It seems to me some of the lines have more than 80 chars (pep8 violation). Maybe pass it through a pep8 formatter.

takumiohym commented on 2024-04-02T19:51:11Z
----------------------------------------------------------------

Modified. Thanks!

review-notebook-app · 2024-03-25T22:06:08Z

View / edit / reply to this conversation on ReviewNB

sanjanalreddy commented on 2024-03-25T22:06:07Z
----------------------------------------------------------------

Can you add a brief explanation of Integrated Gradients here?

takumiohym commented on 2024-03-27T16:57:38Z
----------------------------------------------------------------

Added. Thanks!

review-notebook-app · 2024-03-25T22:07:11Z

View / edit / reply to this conversation on ReviewNB

sanjanalreddy commented on 2024-03-25T22:07:11Z
----------------------------------------------------------------

Very nice! Thank you for adding this notebook!

takumiohym commented on 2024-03-27T16:57:50Z
----------------------------------------------------------------

Thank you for your feedback!

takumiohym · 2024-03-27T16:43:22Z

Makes sense! Added.

View entire conversation on ReviewNB

takumiohym · 2024-03-27T16:50:51Z

Actually this cell and description is taken by the vertex ai explanation notebook.

https://github.com/GoogleCloudPlatform/asl-ml-immersion/blob/master/notebooks/responsible_ai/explainable_ai/solutions/xai_image_vertex.ipynb

I think we can assume the user understand this basic flows as the vertex ai version assumes in this notebook, since it is not the focus.

Anyway I added a reference to another notebook in case students want to review what's going on here. I hope it helps!

View entire conversation on ReviewNB

takumiohym · 2024-03-27T16:53:36Z

Makes sense! Updated.

View entire conversation on ReviewNB

takumiohym · 2024-03-27T16:57:39Z

Added. Thanks!

View entire conversation on ReviewNB

takumiohym · 2024-03-27T16:57:52Z

Thank you for your feedback!

View entire conversation on ReviewNB

BenoitDherin · 2024-03-28T16:08:57Z

I agree with Sanjana. Breaking that long code cell and adding one-liner explanations in markdown will help a lot.

View entire conversation on ReviewNB

BenoitDherin · 2024-03-28T16:12:54Z

Please store the long URL into a separate variable at the beginning of the cell.

It seems to me some of the lines have more than 80 chars (pep8 violation). Maybe pass it through a pep8 formatter.

View entire conversation on ReviewNB

review-notebook-app · 2024-03-28T16:41:15Z

View / edit / reply to this conversation on ReviewNB

BenoitDherin commented on 2024-03-28T16:41:15Z
----------------------------------------------------------------

use Saliency library --> use the Saliency library
to explain the model --> to explain the model predictions
Add a "Learning Objective" to match the style of the other labs
"In this lab you will: " --> "Learning objectives:"

takumiohym commented on 2024-04-02T19:49:46Z
----------------------------------------------------------------

Modified. Thanks!

review-notebook-app · 2024-03-28T16:41:16Z

View / edit / reply to this conversation on ReviewNB

BenoitDherin commented on 2024-03-28T16:41:16Z
----------------------------------------------------------------

* Use "os.path.join" instead of concatenating with "+" (this will avoid issues with "//" or no "/" )

takumiohym commented on 2024-04-02T19:49:55Z
----------------------------------------------------------------

Modified. Thanks!

review-notebook-app · 2024-03-28T16:41:17Z

View / edit / reply to this conversation on ReviewNB

BenoitDherin commented on 2024-03-28T16:41:16Z
----------------------------------------------------------------

This is a long code cell. Maybe break it so that you can explain what the functions are doing in markdown cells above the code cells.

takumiohym commented on 2024-04-02T19:50:42Z
----------------------------------------------------------------

Broke up to multiple cells, and removed unnecessary functions.

review-notebook-app · 2024-03-28T16:41:18Z

View / edit / reply to this conversation on ReviewNB

BenoitDherin commented on 2024-03-28T16:41:17Z
----------------------------------------------------------------

Punctuation: "Now that our image classification model has been trained, let's choose a target image we want to explain, and check the prediction result."

takumiohym commented on 2024-04-02T19:51:24Z
----------------------------------------------------------------

Modified.

review-notebook-app · 2024-03-28T16:41:18Z

View / edit / reply to this conversation on ReviewNB

BenoitDherin commented on 2024-03-28T16:41:18Z
----------------------------------------------------------------

Please break this cell into one code cell per function and explain what these functions are doing in a markdown cell.

takumiohym commented on 2024-04-02T19:52:02Z
----------------------------------------------------------------

Removed these helper functions. Integrated all to a single ShowImage function defined above.

review-notebook-app · 2024-03-28T16:41:19Z

View / edit / reply to this conversation on ReviewNB

BenoitDherin commented on 2024-03-28T16:41:19Z
----------------------------------------------------------------

"Saliency library" --> "the Saliency library"
Maybe define what is a "saliency based explanation" technique here.

takumiohym commented on 2024-04-02T19:52:49Z
----------------------------------------------------------------

Rewrote this section by adding detailed explanations.

review-notebook-app · 2024-03-28T16:41:20Z

View / edit / reply to this conversation on ReviewNB

BenoitDherin commented on 2024-03-28T16:41:19Z
----------------------------------------------------------------

"call_model_function defines " --> "The call_model_function defines "
Define what a "saliency mask" is

takumiohym commented on 2024-04-02T19:53:19Z
----------------------------------------------------------------

Modified, and adde explanations on the saliency methods and masks.

review-notebook-app · 2024-03-28T16:41:22Z

View / edit / reply to this conversation on ReviewNB

BenoitDherin commented on 2024-03-28T16:41:22Z
----------------------------------------------------------------

Explain what an integrated gradient mask is
From the explanation above it's not very clear what "GetMask" and "GetSmoothedMask" are doing. Maybe consider expanding on what is the output of these function and why it is useful.

takumiohym commented on 2024-04-02T19:56:23Z
----------------------------------------------------------------

Added comprehensive explanations.

review-notebook-app · 2024-03-28T16:41:23Z

View / edit / reply to this conversation on ReviewNB

BenoitDherin commented on 2024-03-28T16:41:22Z
----------------------------------------------------------------

Explain what you mean by "integration with segmentation"
XARI --> XRAI

takumiohym commented on 2024-04-02T19:56:56Z
----------------------------------------------------------------

Expanded the entire XRAI explanations.

review-notebook-app · 2024-03-28T16:41:24Z

View / edit / reply to this conversation on ReviewNB

BenoitDherin commented on 2024-03-28T16:41:23Z
----------------------------------------------------------------

Add licence information.

takumiohym commented on 2024-04-02T19:57:06Z
----------------------------------------------------------------

Added. Thanks!

takumiohym · 2024-04-02T19:49:47Z

Modified. Thanks!

View entire conversation on ReviewNB

takumiohym · 2024-04-02T19:49:56Z

Modified. Thanks!

View entire conversation on ReviewNB

takumiohym · 2024-04-02T19:50:43Z

Broke up to multiple cells, and removed unnecessary functions.

View entire conversation on ReviewNB

takumiohym · 2024-04-02T19:50:52Z

Broke up to multiple cells, and removed unnecessary functions.

View entire conversation on ReviewNB

takumiohym · 2024-04-02T19:51:12Z

Modified. Thanks!

View entire conversation on ReviewNB

takumiohym · 2024-04-02T19:51:25Z

Modified.

View entire conversation on ReviewNB

takumiohym · 2024-04-02T19:52:03Z

Removed these helper functions. Integrated all to a single ShowImage function defined above.

View entire conversation on ReviewNB

takumiohym · 2024-04-02T19:52:50Z

Rewrote this section by adding detailed explanations.

View entire conversation on ReviewNB

takumiohym · 2024-04-02T19:53:21Z

Modified, and adde explanations on the saliency methods and masks.

View entire conversation on ReviewNB

takumiohym · 2024-04-02T19:55:33Z

Added explanations!

Regarding the function argument, this is what the Saliency library expects and can't be modified.

I think it's ok given this function is used not for generic purpose, but as a model wrapper to define an extra function for saliency methods.

View entire conversation on ReviewNB

takumiohym · 2024-04-02T19:56:00Z

Added those informations. Thanks!

View entire conversation on ReviewNB

takumiohym · 2024-04-02T19:56:24Z

Added comprehensive explanations.

View entire conversation on ReviewNB

takumiohym · 2024-04-02T19:56:57Z

Expanded the entire XRAI explanations.

View entire conversation on ReviewNB

takumiohym · 2024-04-02T19:57:08Z

Added. Thanks!

View entire conversation on ReviewNB

BenoitDherin · 2024-04-02T20:22:54Z

Thanks! Great!

View entire conversation on ReviewNB

review-notebook-app · 2024-04-02T20:24:41Z

View / edit / reply to this conversation on ReviewNB

BenoitDherin commented on 2024-04-02T20:24:40Z
----------------------------------------------------------------

that build -> that builds

takumiohym commented on 2024-04-03T10:03:38Z
----------------------------------------------------------------

Modified. Thanks!

review-notebook-app · 2024-04-02T20:24:42Z

View / edit / reply to this conversation on ReviewNB

BenoitDherin commented on 2024-04-02T20:24:41Z
----------------------------------------------------------------

Some typos fixed in the suggestion below:

"The code in the cell below contains the training logic. It starts by ingesting the data from GCS, then trains an image classification model using mobileNet as a feature extractor, and at last sends its output feature vector through a tf.keras.dense layer with 5 units (one unit per label) and a softmax activation ."

takumiohym commented on 2024-04-03T10:03:58Z
----------------------------------------------------------------

Modified. Thanks!

review-notebook-app · 2024-04-02T20:24:43Z

View / edit / reply to this conversation on ReviewNB

BenoitDherin commented on 2024-04-02T20:24:43Z
----------------------------------------------------------------

Something is off with the bullet points here. They don't seem to be matching the steps.

takumiohym commented on 2024-04-03T10:06:17Z
----------------------------------------------------------------

It seem it is a bug of this reviewer app. The original markdown was ok. (2. should come before "Compute gradients...")

BenoitDherin

LGTM

takumiohym · 2024-04-03T10:03:39Z

Modified. Thanks!

View entire conversation on ReviewNB

takumiohym · 2024-04-03T10:03:59Z

Modified. Thanks!

View entire conversation on ReviewNB

takumiohym · 2024-04-03T10:06:19Z

It seem it is a bug of this reviewer app. The original markdown was ok. (2. should come before "Compute gradients...")

View entire conversation on ReviewNB

Saliency notebook draft

e7a345f

takumiohym force-pushed the saliency branch from 135cf87 to e7a345f Compare March 14, 2024 19:09

Finalize the saliency solution notebook

02d9aaf

takumiohym marked this pull request as ready for review March 25, 2024 12:33

takumiohym requested review from BenoitDherin, sanjanalreddy, maabel0712 and kylesteckler March 25, 2024 12:34

Reflected feedback

9d2e8d4

takumiohym requested a review from conchitagoogle March 27, 2024 17:53

Reflect feedbacks on XAI notebook

4a4c847

BenoitDherin approved these changes Apr 2, 2024

View reviewed changes

Fix typo

0738c2d

takumiohym merged commit c746c86 into master Apr 3, 2024
5 checks passed

takumiohym deleted the saliency branch April 3, 2024 10:37

takumiohym mentioned this pull request Jun 19, 2024

Add saliency exercise notebook #484

Merged

XAI with Saliency library solution notebook #426

XAI with Saliency library solution notebook #426

Conversation

takumiohym commented Mar 14, 2024 • edited Loading

review-notebook-app bot commented Mar 14, 2024

review-notebook-app bot commented Mar 25, 2024 • edited Loading

review-notebook-app bot commented Mar 25, 2024 • edited Loading

review-notebook-app bot commented Mar 25, 2024 • edited Loading

review-notebook-app bot commented Mar 25, 2024 • edited Loading

review-notebook-app bot commented Mar 25, 2024 • edited Loading

takumiohym commented Mar 27, 2024

takumiohym commented Mar 27, 2024

takumiohym commented Mar 27, 2024

takumiohym commented Mar 27, 2024

takumiohym commented Mar 27, 2024

BenoitDherin commented Mar 28, 2024

BenoitDherin commented Mar 28, 2024

review-notebook-app bot commented Mar 28, 2024 • edited Loading

review-notebook-app bot commented Mar 28, 2024 • edited Loading

review-notebook-app bot commented Mar 28, 2024 • edited Loading

review-notebook-app bot commented Mar 28, 2024 • edited Loading

review-notebook-app bot commented Mar 28, 2024 • edited Loading

review-notebook-app bot commented Mar 28, 2024 • edited Loading

review-notebook-app bot commented Mar 28, 2024 • edited Loading

review-notebook-app bot commented Mar 28, 2024 • edited Loading

review-notebook-app bot commented Mar 28, 2024 • edited Loading

review-notebook-app bot commented Mar 28, 2024 • edited Loading

takumiohym commented Apr 2, 2024

takumiohym commented Apr 2, 2024

takumiohym commented Apr 2, 2024

takumiohym commented Apr 2, 2024

takumiohym commented Apr 2, 2024

takumiohym commented Apr 2, 2024

takumiohym commented Apr 2, 2024

takumiohym commented Apr 2, 2024

takumiohym commented Apr 2, 2024

takumiohym commented Apr 2, 2024

takumiohym commented Apr 2, 2024

takumiohym commented Apr 2, 2024

takumiohym commented Apr 2, 2024

takumiohym commented Apr 2, 2024

BenoitDherin commented Apr 2, 2024

review-notebook-app bot commented Apr 2, 2024 • edited Loading

review-notebook-app bot commented Apr 2, 2024 • edited Loading

review-notebook-app bot commented Apr 2, 2024 • edited Loading

BenoitDherin left a comment

Choose a reason for hiding this comment

takumiohym commented Apr 3, 2024

takumiohym commented Apr 3, 2024

takumiohym commented Apr 3, 2024

takumiohym commented Mar 14, 2024 •

edited

Loading

review-notebook-app bot commented Mar 25, 2024 •

edited

Loading

review-notebook-app bot commented Mar 25, 2024 •

edited

Loading

review-notebook-app bot commented Mar 25, 2024 •

edited

Loading

review-notebook-app bot commented Mar 25, 2024 •

edited

Loading

review-notebook-app bot commented Mar 25, 2024 •

edited

Loading

review-notebook-app bot commented Mar 28, 2024 •

edited

Loading

review-notebook-app bot commented Mar 28, 2024 •

edited

Loading

review-notebook-app bot commented Mar 28, 2024 •

edited

Loading

review-notebook-app bot commented Mar 28, 2024 •

edited

Loading

review-notebook-app bot commented Mar 28, 2024 •

edited

Loading

review-notebook-app bot commented Mar 28, 2024 •

edited

Loading

review-notebook-app bot commented Mar 28, 2024 •

edited

Loading

review-notebook-app bot commented Mar 28, 2024 •

edited

Loading

review-notebook-app bot commented Mar 28, 2024 •

edited

Loading

review-notebook-app bot commented Mar 28, 2024 •

edited

Loading

review-notebook-app bot commented Apr 2, 2024 •

edited

Loading

review-notebook-app bot commented Apr 2, 2024 •

edited

Loading

review-notebook-app bot commented Apr 2, 2024 •

edited

Loading