-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Upgrade to Kubernetes 0.30.1 and associated controller-runtime. #593
base: main
Are you sure you want to change the base?
Conversation
go 1.22 | ||
go 1.22.0 | ||
|
||
toolchain go1.22.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems this was added automatically by go mod tidy
. I'll revert it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, go mod tidy
automatically updates:
go 1.22
to
go 1.22.0
toolchain go1.22.3
Apparently, this is the Go official way now. I think this change is necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a problem with a dependency we're pulling in. See golang/go#62409 as one example. I think we don't want to add the toolchain or the patch version here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hessjcg would you mind taking a closer look at this? This is surprising and unwanted behavior which I think is coming from one of the dependencies here (and might have a tracking bug for it already).
@@ -1,14 +1,16 @@ | |||
module github.com/GoogleCloudPlatform/cloud-sql-proxy-operator | |||
|
|||
go 1.22 | |||
go 1.22.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not just go 1.22?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My only concern here is the unwanted changes to go.mod. That looks like a bad dependency doing this.
go 1.22 | ||
go 1.22.0 | ||
|
||
toolchain go1.22.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hessjcg would you mind taking a closer look at this? This is surprising and unwanted behavior which I think is coming from one of the dependencies here (and might have a tracking bug for it already).
This upgrades the Kuberentes and Controller Runtime libraries to the latest available. It includes fixes for
superficial breaking changes in the Controller Runtime API.