chore: Move dialer options out of cmd/main.go and into internal/proxy.go #1247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oxy.go b/236883514 This consolidates all code relating to cloud.google.com/go/cloudsqlconn into the internal/proxy package. Also, it makes it easier to test the transformation logic from proxy.Config to []cloudsqlconn.Option
hessjcg
changed the title
enocom
changed the title
hessjcg
added
tests: run
enocom
approved these changes
Jun 23, 2022
…oxy.go, address code review nit
enocom
added a commit
to GoogleCloudPlatform/alloydb-auth-proxy
that referenced
this pull request
Jul 8, 2022
enocom
added a commit
to GoogleCloudPlatform/alloydb-auth-proxy
that referenced
this pull request
Jul 8, 2022
enocom
pushed a commit
that referenced
this pull request
Jul 12, 2022
….go (#1247) Move dialer options out of cmd/main.go and into internal/proxy.go. This consolidates all code relating to cloud.google.com/go/cloudsqlconn into the internal/proxy package.
enocom
pushed a commit
that referenced
this pull request
Jul 27, 2022
….go (#1247) Move dialer options out of cmd/main.go and into internal/proxy.go. This consolidates all code relating to cloud.google.com/go/cloudsqlconn into the internal/proxy package.
enocom
pushed a commit
that referenced
this pull request
Aug 23, 2022
….go (#1247) Move dialer options out of cmd/main.go and into internal/proxy.go. This consolidates all code relating to cloud.google.com/go/cloudsqlconn into the internal/proxy package.
enocom
pushed a commit
that referenced
this pull request
Aug 29, 2022
….go (#1247) Move dialer options out of cmd/main.go and into internal/proxy.go. This consolidates all code relating to cloud.google.com/go/cloudsqlconn into the internal/proxy package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This consolidates all code relating to cloud.google.com/go/cloudsqlconn into the internal/proxy package.