Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update version.txt for v1 branch (#1836) #1904

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

annafang-google
Copy link
Contributor

v1 branch will have version.txt moved to proxy/util folder. Update the release_please.xml file with the new location.

@annafang-google annafang-google requested a review from a team as a code owner August 11, 2023 17:18
@jackwotherspoon jackwotherspoon changed the title fix: Update version.txt for v1 branch (#1836) chore: update version.txt for v1 branch (#1836) Aug 11, 2023
@jackwotherspoon
Copy link
Collaborator

jackwotherspoon commented Aug 11, 2023

@annafang-google I updated this to a chore: as the release-please update is a not a bug fix in my eyes. We also don't want this showing up in the changelog for v2 which a fix: prefix would do.

@annafang-google
Copy link
Contributor Author

@annafang-google I updated this to a chore: as the release-please update is a not a bug fix in my eyes. We also don't want this showing up in the changelog for v2 which a fix: prefix would do.

Makes sense!

@annafang-google annafang-google merged commit 1f56f65 into main Aug 15, 2023
12 checks passed
@annafang-google annafang-google deleted the update-version-v1 branch August 15, 2023 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants