-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: callback notify function when connection is refused #2308
Conversation
@chechenglin I am trying to think if there is an easy way to test this new option... |
@chechenglin I think we could probably update the cloud-sql-proxy/internal/proxy/proxy_test.go Line 363 in 2985def
|
Good call. I just realized I did not update the caller in the tests. I'll need to update those callers. Will push a amend commit soon. |
Remove uninteresting argument in the callback function.
Revised. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @chechenglin! LGTM ✅
@enocom do you mind doing a review before we go ahead and merge this
Looks like
|
Add a command option for adding a callback function for the connection refuse events due to max connection limit.