Add functionality to modify record tag for matched exceptions #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, @igorpeshansky @qingling128, could you please review this and merge/release if everything looks good? Thanks! |
davidbtucker
requested review from
jkschulz and
sophieyfang
and removed request for
sophieyfang
|
Hey @jkschulz, |
|
Hey @jkschulz, any update here? |
|
Still no feedback about this PR :( |
|
Hey guys, one more reminder. More than 6 months passed. Is there any chance to get this merged? |
|
Any update here? Should we prepare to celebrate the birthday? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #54 and potentially #67 (records with exception could be tagged differently, for example with tag prefix
exceptionwhich can be later forwarded to thefluent-plugin-record-modifierto enrich message).