-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding HappyBase Connection.create_table(). #1502
Conversation
family options as the values. The options can be among | ||
|
||
* :class:`dict` | ||
* :class:`.GarbageCollectionRule` |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Do all the possible options (dict keys) control only garbage collection? |
The only fields for a table (other than a You're right in wondering though. I'd imagine if at some point the Thrift/HBase table settings
then we'd have a re-design on our hands. |
10d0ea4
to
91be693
Compare
How big of a n00b am I! I closed this by accident (from the command line) the exact same way I closed #1501. |
@tseaver Does my explanation make sense? |
result = option | ||
if isinstance(result, dict): | ||
if not set(result.keys()) <= set(['max_versions', 'time_to_live']): | ||
raise ValueError('Cloud Bigtable only supports max_versions and ' |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
c988088
to
35b5e8d
Compare
@jonparrott I changed the exception to a warning in |
LGTM, barring the question about atomicity. (don't forget to squash) |
OK. Will squash and merge and file an issue to follow up. |
SGTM. |
35b5e8d
to
c001fb9
Compare
Adding HappyBase Connection.create_table().
@tseaver sorry #1501 got closed. I did a
git push -f
after rebase-ing and it just pushed theHEAD
ofmaster
(which GitHub interpreted as a delete).