Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STORAGE: Removing project from Connection. #733

Merged
merged 1 commit into from
Mar 17, 2015

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Mar 14, 2015

Only needed for create_bucket() and get_all_buckets().

Fixes #726.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 14, 2015
@dhermes dhermes added the api: storage Issues related to the Cloud Storage API. label Mar 14, 2015
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 068b9fa on dhermes:detach-project-from-connection into d668044 on GoogleCloudPlatform:master.

@dhermes
Copy link
Contributor Author

dhermes commented Mar 14, 2015

Maybe we should add project as a keyword argument to _BucketIterator.

@tseaver
Copy link
Contributor

tseaver commented Mar 16, 2015

LGTM

Only needed for create_bucket() and get_all_buckets().

Fixes googleapis#726.
@dhermes dhermes force-pushed the detach-project-from-connection branch from 068b9fa to b91b2af Compare March 17, 2015 17:58
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling b91b2af on dhermes:detach-project-from-connection into * on GoogleCloudPlatform:master*.

dhermes added a commit that referenced this pull request Mar 17, 2015
STORAGE: Removing project from Connection.
@dhermes dhermes merged commit 8178991 into googleapis:master Mar 17, 2015
@dhermes dhermes deleted the detach-project-from-connection branch March 17, 2015 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

STORAGE: Which requests require a project?
4 participants