Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STORAGE: Which requests require a project? #726

Closed
dhermes opened this issue Mar 13, 2015 · 2 comments · Fixed by #733
Closed

STORAGE: Which requests require a project? #726

dhermes opened this issue Mar 13, 2015 · 2 comments · Fixed by #733
Assignees
@dhermes
Labels
api: storage Issues related to the Cloud Storage API.
Milestone
Storage Stable

Comments

@dhermes
Copy link
Contributor

dhermes commented Mar 13, 2015

Grepping through the JSON discovery spec for "project" it only occurs in

storage.buckets.insert
storage.buckets.list

yet we send it with every single request:

    def build_api_url(self, path, query_params=None, api_base_url=None,
                      api_version=None, upload=False):
        ...
        query_params.update({'project': self.project})
        ...

/cc @thobrla
@dhermes dhermes added the api: storage Issues related to the Cloud Storage API. label Mar 13, 2015
@dhermes dhermes added this to the Storage Stable milestone Mar 13, 2015
@thobrla
Copy link

thobrla commented Mar 14, 2015

Yes, project is only meaningful for the two requests you mentioned.

dhermes added a commit to dhermes/google-cloud-python that referenced this issue Mar 14, 2015
@dhermes
STORAGE: Removing project from Connection.
068b9fa 
Only needed for create_bucket() and get_all_buckets().

Fixes googleapis#726.
This was referenced Mar 14, 2015
Merged
Closed
@dhermes
Copy link
Contributor Author

dhermes commented Mar 14, 2015

Great! @tseaver I made a PR to remove project from Connection and just use project in create_bucket and get_all_buckets.

dhermes added a commit to dhermes/google-cloud-python that referenced this issue Mar 17, 2015
@dhermes
STORAGE: Removing project from Connection.
b91b2af 
Only needed for create_bucket() and get_all_buckets().

Fixes googleapis#726.
@dhermes dhermes mentioned this issue Apr 16, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dhermes dhermes

Labels
api: storage Issues related to the Cloud Storage API.
Projects
None yet
Milestone
Storage Stable
Development

Successfully merging a pull request may close this issue.

STORAGE: Removing project from Connection. dhermes/google-cloud-python
2 participants
@dhermes @thobrla