-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[testing-on-gke enhancements] remove mash dependency #2547
Open
gargnitingoogle
wants to merge
2
commits into
garnitin/add-gke-load-testing/upload-outputs-to-gsheet
Choose a base branch
from
garnitin/add-gke-load-testing/enhancements/remove-mash-dependency
base: garnitin/add-gke-load-testing/upload-outputs-to-gsheet
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+61
−230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/upload-outputs-to-gsheet
branch
from
October 3, 2024 17:47
a998865
to
ed56ec3
Compare
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/enhancements/remove-mash-dependency
branch
2 times, most recently
from
October 3, 2024 19:23
3124adf
to
3597a49
Compare
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/upload-outputs-to-gsheet
branch
from
October 4, 2024 05:37
d50d8d8
to
e6a68ea
Compare
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/enhancements/remove-mash-dependency
branch
from
October 4, 2024 05:37
3597a49
to
0e196fe
Compare
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/enhancements/remove-mash-dependency
branch
from
October 4, 2024 10:05
0e196fe
to
ce3610e
Compare
kislaykishore
approved these changes
Oct 4, 2024
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/upload-outputs-to-gsheet
branch
from
October 7, 2024 10:10
e6a68ea
to
d074035
Compare
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/enhancements/remove-mash-dependency
branch
from
October 7, 2024 10:10
ce3610e
to
d89519e
Compare
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/upload-outputs-to-gsheet
branch
from
October 7, 2024 10:26
d074035
to
cc74d73
Compare
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/enhancements/remove-mash-dependency
branch
from
October 7, 2024 10:26
d89519e
to
c84442d
Compare
Purposes. * Consistent behavior across all machines * Monitoring API has faster runtime than mash. * Monitoring API is supported on GCE VM too.
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/upload-outputs-to-gsheet
branch
from
October 7, 2024 10:29
cc74d73
to
80a4844
Compare
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/enhancements/remove-mash-dependency
branch
from
October 7, 2024 10:29
c84442d
to
ed644a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace mash with monitoring-api everywhere
Purposes:
Link to the issue in case of a bug fix.
NA
Testing details