Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gimmeproj): improve version information using embedded build data #4260

Merged
merged 19 commits into from
Oct 25, 2024

Conversation

muncus
Copy link
Collaborator

@muncus muncus commented Jul 9, 2024

Description

Improves build version info from gimmeproj version to include git source and
sha, as well as build time. this embedded data is present for all builds and
works on go 1.16+.

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed Contributing Guidelines from CONTRIBUTING.MD
  • Tests pass: go test -v ./.. (see Testing)
  • Code formatted: gofmt (see Formatting)
  • Vetting pass: go vet (see Formatting)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@muncus muncus requested a review from a team as a code owner July 9, 2024 17:15
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jul 9, 2024
@subfuzion subfuzion added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 5, 2024
@subfuzion subfuzion self-assigned this Aug 5, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 23, 2024
@telpirion telpirion requested a review from a team as a code owner September 23, 2024 22:26
@telpirion telpirion self-assigned this Sep 26, 2024
@telpirion telpirion requested review from a team as code owners September 30, 2024 16:23
@muncus
Copy link
Collaborator Author

muncus commented Oct 25, 2024

Failing tests are for spanner and dataproc, which are known to be broken.

@muncus muncus merged commit 582adde into main Oct 25, 2024
10 of 11 checks passed
@muncus muncus deleted the gimmeproj-version branch October 25, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants