Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(build): bump earliest kokoro build version to go121 #4360

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

chore(build): bump earliest kokoro build version to go121 #4360

wants to merge 4 commits into from

Conversation

subfuzion
Copy link
Member

@subfuzion subfuzion commented Sep 3, 2024 •
edited
Loading

Bumping earliest Kokoro test go version to go121. Bumping latest version to go123 will be submitted in a separate, forthcoming PR.

This should solve the breakage we're seeing from the go.mod version format change between 1.20 and 1.21. For example:

go: errors parsing go.mod:
/[tmpfs/src/github/golang-samples/opentelemetry/instrumentation/app/go.mod:3](https://cs.corp.google.com/piper///depot/google3/tmpfs/src/github/golang-samples/opentelemetry/instrumentation/app/go.mod?l=3):
invalid go version '1.21.0': must match format 1.23

@subfuzion subfuzion requested a review from a team as a code owner September 3, 2024 22:56
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Sep 3, 2024
telpirion
telpirion approved these changes Sep 5, 2024
View reviewed changes
Copy link
Collaborator

@telpirion telpirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we have the requisite approvals, but I'll add mine just in case.

@telpirion telpirion self-assigned this Sep 23, 2024
@telpirion telpirion requested a review from a team as a code owner September 27, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iennae iennae iennae approved these changes

@telpirion telpirion telpirion approved these changes

@grayside grayside Awaiting requested review from grayside

Assignees

@telpirion telpirion

Labels
samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@subfuzion @iennae @telpirion