Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(firestore): Distance result field and distance threshold in vector search #4362

Merged
merged 12 commits into from
Sep 17, 2024

Conversation

bhshkh
Copy link
Contributor

@bhshkh bhshkh commented Sep 5, 2024

Checklist

  • I have followed Contributing Guidelines from CONTRIBUTING.MD
  • Tests pass: go test -v ./.. (see Testing)
  • Code formatted: gofmt (see Formatting)
  • Vetting pass: go vet (see Formatting)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label bot added api: firestore Issues related to the Firestore API. samples Issues that are directly related to samples. labels Sep 5, 2024
@bhshkh
Copy link
Contributor Author

bhshkh commented Sep 5, 2024

@bhshkh bhshkh added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 5, 2024
@bhshkh bhshkh marked this pull request as ready for review September 11, 2024 23:54
@bhshkh bhshkh requested review from a team as code owners September 11, 2024 23:54
Copy link

snippet-bot bot commented Sep 11, 2024

Here is the summary of changes.

You are about to add 3 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@bhshkh bhshkh removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 12, 2024
@bhshkh bhshkh enabled auto-merge (squash) September 12, 2024 00:12
@telpirion telpirion self-assigned this Sep 12, 2024
Copy link
Collaborator

@telpirion telpirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only small nits--address as you see fit. I'll merge this PR after your next comment. Thanks!

firestore/vector_search_distance_threshold.go Show resolved Hide resolved
firestore/vector_search_result_field.go Show resolved Hide resolved
@bhshkh bhshkh enabled auto-merge (squash) September 17, 2024 16:56
@bhshkh bhshkh merged commit 47eea43 into GoogleCloudPlatform:main Sep 17, 2024
9 checks passed
@bhshkh bhshkh deleted the feature/fs-vector-search-02 branch September 18, 2024 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the Firestore API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants