fix(healthcare): replace deprecated NotificationConfig with FhirNotificationConfig #4377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
api: healthcare
telpirion
requested changes
Sep 12, 2024
healthcare/fhir_store_patch.go
Outdated
| PubsubTopic: topicName, // format is "projects/*/locations/*/topics/*" | ||
| } | ||
|
|
||
| if _, err := storesService.Patch(name, &healthcare.FhirStore{NotificationConfigs: []*healthcare.FhirNotificationConfig{notificationConfig}}).UpdateMask("notificationConfigs").Do(); err != nil { |
There was a problem hiding this comment.
issue: initialize the healthcare.FhirStore object and call UpdateMask() outside of this block.
This is difficult to read as written.
No region tags are edited in this PR.This comment is generated by snippet-bot.
|
noerog
force-pushed
the
hcapi-notificationconfig
branch
from
7bcbd07
to
a54801e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes b/310269530
Checklist
go test -v ./..(see Testing)gofmt(see Formatting)go vet(see Formatting)