Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cloudrun): update practices from deprecated ioutil to io #4408

Merged
merged 3 commits into from
Sep 27, 2024

Conversation

iennae
Copy link
Contributor

@iennae iennae commented Sep 27, 2024

Description

Fixes b/368461774

  • ioutil is deprecated so move to io
  • while io.ReadAll closes r.Body internally, recommended practice is to explicitly do resource management and provide clarity.

Checklist

  • I have followed Contributing Guidelines from CONTRIBUTING.MD
  • Tests pass: go test -v ./.. (see Testing)
  • Code formatted: gofmt (see Formatting)
  • Vetting pass: go vet (see Formatting)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@iennae iennae requested review from a team as code owners September 27, 2024 02:23
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Sep 27, 2024
@telpirion telpirion self-assigned this Sep 27, 2024
@telpirion telpirion merged commit 6e7b24c into main Sep 27, 2024
11 checks passed
@telpirion telpirion deleted the sigje-ioutil-368461774 branch September 27, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants