-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: regional template operations samples #4412
Conversation
Here is the summary of changes. You are about to add 3 region tags.
This comment is generated by snippet-bot.
|
@@ -207,4 +207,40 @@ func TestCreateInstanceTemplatesSnippets(t *testing.T) { | |||
if err = op.Wait(ctx); err != nil { | |||
t.Errorf("unable to wait for the operation: %v", err) | |||
} | |||
|
|||
t.Run("regional template", func(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue: break these into individual tests methods. We should ideally have one test method for each sample.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair. I've split the test into smaller chunks as you suggested - one per sample.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Description
Created basic operations for regional templates
Checklist
go test -v ./..
(see Testing)gofmt
(see Formatting)go vet
(see Formatting)