Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: regional template operations samples #4412

Merged
merged 3 commits into from
Oct 1, 2024

Conversation

BigBlackWolf
Copy link
Contributor

Description

Created basic operations for regional templates

Checklist

  • I have followed Contributing Guidelines from CONTRIBUTING.MD
  • Tests pass: go test -v ./.. (see Testing)
  • Code formatted: gofmt (see Formatting)
  • Vetting pass: go vet (see Formatting)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Sep 30, 2024
@BigBlackWolf BigBlackWolf marked this pull request as ready for review September 30, 2024 09:58
@BigBlackWolf BigBlackWolf requested review from a team as code owners September 30, 2024 09:58
@BigBlackWolf BigBlackWolf enabled auto-merge (squash) September 30, 2024 09:59
Copy link

snippet-bot bot commented Sep 30, 2024

Here is the summary of changes.

You are about to add 3 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@@ -207,4 +207,40 @@ func TestCreateInstanceTemplatesSnippets(t *testing.T) {
if err = op.Wait(ctx); err != nil {
t.Errorf("unable to wait for the operation: %v", err)
}

t.Run("regional template", func(t *testing.T) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: break these into individual tests methods. We should ideally have one test method for each sample.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair. I've split the test into smaller chunks as you suggested - one per sample.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@BigBlackWolf BigBlackWolf merged commit 66760d0 into main Oct 1, 2024
10 checks passed
@BigBlackWolf BigBlackWolf deleted the feat_regional_templates branch October 1, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants