Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test CLA / write permissions / CI builds #4414

Closed

Conversation

Valeriy-Burlaka
Copy link
Member

@Valeriy-Burlaka Valeriy-Burlaka commented Oct 1, 2024

Description

Tests my CLA and write permissions. Please ignore.

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed Contributing Guidelines from CONTRIBUTING.MD
  • Tests pass: go test -v ./.. (see Testing)
  • Code formatted: gofmt (see Formatting)
  • Vetting pass: go vet (see Formatting)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@Valeriy-Burlaka Valeriy-Burlaka requested review from a team as code owners October 1, 2024 13:33
@Valeriy-Burlaka Valeriy-Burlaka self-assigned this Oct 1, 2024
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Oct 1, 2024
@Valeriy-Burlaka Valeriy-Burlaka marked this pull request as draft October 1, 2024 14:06
@Valeriy-Burlaka Valeriy-Burlaka changed the title test CLA & write permissions test CLA / write permissions / CI builds Oct 1, 2024
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@telpirion
Copy link
Collaborator

Thank you for your interest in submitting code to our repo!

It looks like your CLA has been accepted. Do take a look at Conventional Commits, as that is a standard that we observe in this repo. Also be sure to look at the CONTRIBUTING_GUIDE and Samples Style Guide.

@telpirion telpirion closed this Oct 1, 2024
@Valeriy-Burlaka
Copy link
Member Author

Thank you @telpirion ! Will do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants