Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: batch predict code and text generation #4417

Merged
merged 3 commits into from
Oct 4, 2024
Merged

Conversation

BigBlackWolf
Copy link
Contributor

Description

As a base sample was taken GoogleCloudPlatform/python-docs-samples#12543

Checklist

  • I have followed Contributing Guidelines from CONTRIBUTING.MD
  • Tests pass: go test -v ./.. (see Testing)
  • Code formatted: gofmt (see Formatting)
  • Vetting pass: go vet (see Formatting)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Oct 2, 2024
@BigBlackWolf BigBlackWolf marked this pull request as ready for review October 3, 2024 13:13
@BigBlackWolf BigBlackWolf requested review from a team as code owners October 3, 2024 13:13
Copy link

snippet-bot bot commented Oct 3, 2024

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

return err
}

client, err := aiplatform.NewJobClient(ctx, option.WithEndpoint(apiEndpoint))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: does this client need a 'defer client.Close()'?

@BigBlackWolf BigBlackWolf merged commit c4902dd into main Oct 4, 2024
11 checks passed
@BigBlackWolf BigBlackWolf deleted the feat_batch_predict branch October 4, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants