Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update sample acceptance policy #4418

Merged
merged 1 commit into from
Oct 2, 2024
Merged

fix: update sample acceptance policy #4418

merged 1 commit into from
Oct 2, 2024

Conversation

iennae
Copy link
Contributor

@iennae iennae commented Oct 2, 2024

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed Contributing Guidelines from CONTRIBUTING.MD
  • Tests pass: go test -v ./.. (see Testing)
  • Code formatted: gofmt (see Formatting)
  • Vetting pass: go vet (see Formatting)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@iennae iennae requested review from a team as code owners October 2, 2024 16:05
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Oct 2, 2024
@telpirion telpirion merged commit 7c4f707 into main Oct 2, 2024
11 checks passed
@telpirion telpirion deleted the sigje-patch-policy branch October 2, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants