Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create secondary disk sample #4513

Closed
wants to merge 5 commits into from

Conversation

BigBlackWolf
Copy link
Contributor

@BigBlackWolf BigBlackWolf commented Nov 6, 2024

Description

Snippet demonstrates how to create secondary disk. Documentation reference: https://cloud.google.com/compute/docs/disks/async-pd/configure#create_a_secondary_disk

PRs chain:

  1. feat: create secondary disk sample #4513
  2. feat: create secondary disk on regional level and with custom guest features #4532
  3. feat: start/stop async replication samples #4569

Checklist

  • I have followed Contributing Guidelines from CONTRIBUTING.MD
  • Tests pass: go test -v ./.. (see Testing)
  • Code formatted: gofmt (see Formatting)
  • Vetting pass: go vet (see Formatting)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Nov 6, 2024
@BigBlackWolf BigBlackWolf added the api: compute Issues related to the Compute Engine API. label Nov 6, 2024
@BigBlackWolf BigBlackWolf marked this pull request as ready for review November 6, 2024 11:20
@BigBlackWolf BigBlackWolf requested review from a team as code owners November 6, 2024 11:20
@BigBlackWolf BigBlackWolf enabled auto-merge (squash) November 6, 2024 11:21
Copy link

snippet-bot bot commented Nov 6, 2024

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@BigBlackWolf BigBlackWolf force-pushed the feat_compute_disk_create_secondary branch from a028de3 to aaebef4 Compare November 6, 2024 11:45
@BigBlackWolf BigBlackWolf force-pushed the feat_compute_disk_create_secondary branch from aaebef4 to a233bc3 Compare November 8, 2024 12:43
auto-merge was automatically disabled November 15, 2024 11:27

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: compute Issues related to the Compute Engine API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants