feat(gen ai): add parameter example to evaluation samples #4568
Conversation
product-auto-label
bot
added
the
samples
| @@ -29,6 +29,7 @@ import ( | |||
| // evaluateModelResponse evaluates the output of an LLM for groundedness, i.e., how well | |||
| // the model response connects with verifiable sources of information | |||
| func evaluateModelResponse(w io.Writer, projectID, location string) error { | |||
| // location := "us-central1" | |||
There was a problem hiding this comment.
@telpirion , all existing Go samples have this line, but I wonder if it shouldn't be a re-assignment (=) instead of a fresh assignment (:=)? i.e.:
// location = "us-central1"With the current version, if I copy a sample and un-comment this line, I will immediately have no new variables on left side of := ... compiler error. While with the = version I'll immediately have a working version of the sample.
What do you think?
There was a problem hiding this comment.
Yeah, what you say makes sense. We had written some of the other samples with the thought that users would copy the func, delete the args (or most of them), and then uncomment the variable assignments in the func body.
We haven't received any feedback on this from users (that I'm aware of), so this may be a trivial issue.
| @@ -29,6 +29,7 @@ import ( | |||
| // evaluateModelResponse evaluates the output of an LLM for groundedness, i.e., how well | |||
| // the model response connects with verifiable sources of information | |||
| func evaluateModelResponse(w io.Writer, projectID, location string) error { | |||
| // location := "us-central1" | |||
There was a problem hiding this comment.
Yeah, what you say makes sense. We had written some of the other samples with the thought that users would copy the func, delete the args (or most of them), and then uncomment the variable assignments in the func body.
We haven't received any feedback on this from users (that I'm aware of), so this may be a trivial issue.
telpirion
changed the title
Valeriy-Burlaka
deleted the
vburlaka-aiplatform-evaluation-samples-chore
branch
Description
Adds example value for the
locationargument to all evaluation samples (I missed to add this in the scope of #4514)Checklist
go test -v ./..gofmtgo vet