Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pubsub - Set timeout on ack method #1979

Closed
askmon opened this issue Feb 10, 2017 · 2 comments
Closed

Pubsub - Set timeout on ack method #1979

askmon opened this issue Feb 10, 2017 · 2 comments
Assignees
Labels
api: pubsub Issues related to the Pub/Sub API. priority: p2 Moderately-important priority. Fix may not be included in next release.

Comments

@askmon
Copy link

askmon commented Feb 10, 2017

Environment details

  • OS: Ubuntu 14.04
  • Node.js version: 4.4.2
  • npm version: 2.15.9
  • google-cloud-node version: 0.46.2

For some reason, this past week, I started to see that some of my messages were not being acked/delivered, and I have to wait for the ack deadline, as in this image:
image

I tried updating pubsub but wasn't successful.

I'd like to be able to set a timeout on ack request, so after some time it'd give me an error and I'd be able to retry the ack.

I found this on stackoverflow: http://stackoverflow.com/questions/41901108/acked-messages-are-lingering-at-the-google-pubsub it's very similar to what happens to me, but I don't know how I'd change the grpc behavior like this....

@stephenplusplus stephenplusplus added enhancement api: pubsub Issues related to the Pub/Sub API. labels Feb 10, 2017
@stephenplusplus
Copy link
Contributor

Thanks for reporting. As you've noticed, this currently isn't possible. To support, we would just need to allow an options.timeout property to the ack method, which we would pass through to gax. PR welcome if you're up for it!

@stephenplusplus
Copy link
Contributor

Fixed in #2042.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API. priority: p2 Moderately-important priority. Fix may not be included in next release.
Projects
None yet
Development

No branches or pull requests

4 participants